Skip to content

Use Assert.DoesNotContain instead of Assert.IsFalse in DecorateSbomTargetTests#157

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-assert-usage-in-tests
Mar 2, 2026
Merged

Use Assert.DoesNotContain instead of Assert.IsFalse in DecorateSbomTargetTests#157
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-assert-usage-in-tests

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

Pull Request

Description

Fixes two MSTEST0037 code smell warnings by replacing Assert.IsFalse(output.Contains(...)) with the MSTest V4 Assert.DoesNotContain API:

// Before
Assert.IsFalse(output.Contains("SpdxTool: Decorating SBOM"), "...");

// After
Assert.DoesNotContain("SpdxTool: Decorating SBOM", output, "...");

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Affects SingleTfmProject_DecorateSbomFalse_SkipsDecoration and SingleTfmProject_GenerateSbomFalse_SkipsEntirely in DecorateSbomTargetTests.cs.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…etTests

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix MSTest API usage in DecorateSbomTargetTests Use Assert.DoesNotContain instead of Assert.IsFalse in DecorateSbomTargetTests Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants