Closed
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add issues reporting to SonarQualityResult
Add issues to report with branch filtering
Jan 20, 2026
Malcolmnixon
requested changes
Jan 20, 2026
| CancellationToken cancellationToken) | ||
| { | ||
| // Build the URL with query parameters | ||
| var url = $"{reportTask.ServerUrl.TrimEnd('/')}/api/issues/search?componentKeys={reportTask.ProjectKey}&ps=500&issueStatuses=OPEN,CONFIRMED&updatedAfter={updatedAfter}"; |
Member
There was a problem hiding this comment.
Rather than doing the TrimEnd everywhere it's used - hows about trimming it when reading the ReportTask information, or even creating a ServerUrlTrimmed property to hide the trimming implementation.
Contributor
Author
There was a problem hiding this comment.
Moved the trimming to ReportTaskParser.Parse() where the ServerUrl is read. This removes the need for TrimEnd calls throughout SonarQubeClient. Fixed in 23cb814.
…where Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Merged
21 tasks
Copilot AI
added a commit
that referenced
this pull request
Mar 27, 2026
…g template PRs - PR #65: Rename docs folders to standard names: - docs/buildnotes/ -> docs/build_notes/ - docs/quality/ -> docs/code_quality/ - docs/requirements/ + docs/justifications/ -> docs/requirements_doc/ - docs/tracematrix/ -> docs/requirements_report/ - PR #65: Update build.yaml paths for all renamed folders - PR #65: Update .gitignore with new folder paths - PR #65: Update .cspell.yaml words (build_notes, code_quality, etc.) - PR #65: Update .reviewmark.yaml (add bin exclusion, update comment) - PR #24: Update CONTRIBUTING.md and PR template with unit test/self-validation terminology - PR #27/#65: Update PR template linting section to use lint.sh Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/6186d6a3-a30a-42f2-a075-5c1d62feb92c Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
added a commit
that referenced
this pull request
Mar 27, 2026
… TemplateDotNetTool (#105) * Initial plan * feat: update repo-consistency agent with latest simplified version from TemplateDotNetTool Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/8afcbf80-130d-4fbd-b4ed-bbf6829f1265 * feat: apply template improvements from TemplateDotNetTool PRs #58-#75 - Rename all agent files to *.agent.md naming convention with proper YAML frontmatter (tools field, user-invocable, kebab-case names) - Add code-review.agent.md (PR #59) - Update AGENTS.md: add Code Review Agent, use @agent call syntax - Update CONTRIBUTING.md: agent glob to *.agent.md, lint script - Migrate .cspell.json → .cspell.yaml with policy header (PR #63) - Migrate .markdownlint-cli2.jsonc → .markdownlint-cli2.yaml (PR #64) - Update .yamllint.yaml with standards header, .venv/ ignore (PR #64) - Rewrite lint.sh/lint.bat to self-install npm/pip dependencies (PR #61) - Update package.json with cspell and markdownlint-cli2 (PR #61) - Add pip-requirements.txt pinning yamllint==1.38.0 (PR #61) - Update .gitignore to add .venv/ (PR #61) - Add .gitattributes for LF line endings (PR #71) - Update build.yaml: replace 3 lint actions with Node.js+Python+lint.sh (PR #61) - Update release.yaml: remove 'Move buildnotes' step (PR #75)" Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/faf526d1-b8d3-4731-a959-9925242e1f94 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * feat: add ReviewMark integration (PR #58 from TemplateDotNetTool) - Add .reviewmark.yaml with SonarMark-specific review sets - Add demaconsulting.reviewmark 0.2.0 to .config/dotnet-tools.json - Update .versionmark.yaml: add reviewmark entry, pre-release regex on all tools - Update .gitignore: exclude generated review plan/report docs - Create docs/code_review_plan/ (definition.yaml, title.txt, introduction.md) - Create docs/code_review_report/ (definition.yaml, title.txt, introduction.md) - Update build.yaml: add reviewmark to versionmark capture, self-validation, review plan/report generation, HTML/PDF generation, and upload" Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/34424117-a082-453c-accd-84cd9b08f24e Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Apply TemplateDotNetTool PRs #39, #47, #50 consistency updates - PR #39: Add CLA sentence to README.md License section - PR #47: Update Code Analysis ItemGroup comments in main csproj to use inline child-element comment style; add inline comments for coverlet.collector and Code Analysis packages in test csproj - PR #50: Fix Assert.HasCount parameter order in CONTRIBUTING.md (expectedCount before collection); fix UTF-8 encoding description in CONTRIBUTING.md and AGENTS.md (remove BOM reference) Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * feat: apply TemplateDotNetTool PR #65 folder restructure and remaining template PRs - PR #65: Rename docs folders to standard names: - docs/buildnotes/ -> docs/build_notes/ - docs/quality/ -> docs/code_quality/ - docs/requirements/ + docs/justifications/ -> docs/requirements_doc/ - docs/tracematrix/ -> docs/requirements_report/ - PR #65: Update build.yaml paths for all renamed folders - PR #65: Update .gitignore with new folder paths - PR #65: Update .cspell.yaml words (build_notes, code_quality, etc.) - PR #65: Update .reviewmark.yaml (add bin exclusion, update comment) - PR #24: Update CONTRIBUTING.md and PR template with unit test/self-validation terminology - PR #27/#65: Update PR template linting section to use lint.sh Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/6186d6a3-a30a-42f2-a075-5c1d62feb92c Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * feat: update release.yaml to reference build_notes.md (PR #65) Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/6186d6a3-a30a-42f2-a075-5c1d62feb92c Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Update .github/workflows/build.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: add shell: bash to all Pandoc HTML generation steps in build.yaml All Pandoc steps using $(date +'%Y-%m-%d') bash command substitution now explicitly specify shell: bash so they work correctly on windows-latest runners. Agent-Logs-Url: https://github.com/demaconsulting/SonarMark/sessions/58acfc2e-a04e-43d2-a61e-038edb985428 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> Co-authored-by: Malcolm Nixon <Malcolm.nixon@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--branchcommand-line argument to Context classSummary
Successfully implemented feature to add SonarQube issues to the markdown report:
--branchcommand-line option (falls back to GITHUB_REF environment variable)/api/issues/searchAPI with proper URL encodingOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.