Add --result as legacy alias for --results argument#97
Merged
Malcolmnixon merged 2 commits intomainfrom Apr 13, 2026
Merged
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 13, 2026 19:23
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a backward-compatible --result CLI flag as a legacy alias for --results, with traceability captured in design docs and ReqStream requirements.
Changes:
- Added
--resultfallthrough handling to the CLI argument parser (Context.ParseArgument). - Added a CLI subsystem test verifying
--resultsetsResultsFile. - Updated design and ReqStream docs/requirements to capture the legacy alias and its traceability.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DemaConsulting.SarifMark.Tests/Cli/CliTests.cs | Adds subsystem test coverage for the legacy --result alias. |
| src/DemaConsulting.SarifMark/Cli/Context.cs | Implements --result as a fallthrough alias to --results. |
| docs/reqstream/sarifmark/cli/context.yaml | Adds Context-level requirement for the alias (but currently links to a Cli_* test). |
| docs/reqstream/sarifmark/cli/cli.yaml | Adds CLI-level requirement for accepting --result. |
| docs/design/sarifmark/cli/context.md | Documents --result as a legacy alias in the design argument/property table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@copilot Please fix issues reported by linting. |
…tsFile unit test Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/ab80a80d-fa69-4288-a36c-9f2040dcf4b1 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Contributor
Author
Fixed in commit 50ed83e:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds
--resultas a backwards-compatible legacy alias for--results. The alias is intentionally undocumented in the README and user guide — captured only in design docs and requirements for traceability.Changes:
Context.cs): Switch fallthroughcase "--result":→case "--results":with a comment marking it as a legacy aliasCliTests.cs): AddedCli_ResultLegacyAlias_SetsResultsFilePathsubsystem testContextTests.cs): AddedContext_Create_ResultLegacyAlias_SetsResultsFileunit test for direct parsing coveragedocs/design/sarifmark/cli/context.md):--resultdocumented as legacy alias in a note below the properties table; table formatting fixed for lint compliancedocs/reqstream/sarifmark/cli/cli.yaml,context.yaml): AddedSarifMark-Cli-ResultLegacyAliasandSarifMark-Context-ResultLegacyAliasrequirements with proper traceability linkage to their respective test levels; requirement title shortened for lint complianceType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
--resultis deliberately absent from the README and user guide. New users should use--results;--resultexists solely for backwards compatibility and is tracked only in design documentation and requirements traceability.The
SarifMark-Context-ResultLegacyAliasrequirement incontext.yamllinks to theContext_Create_*unit test (matching the hierarchy for all other context-level requirements), whileSarifMark-Cli-ResultLegacyAliasincli.yamllinks to theCli_*subsystem test.