Skip to content

chore: sync AGENTS.md, agent definitions, standards, and lint scripts from TemplateDotNetTool#94

Merged
Malcolmnixon merged 1 commit intomainfrom
copilot/binary-copy-updated-files
Apr 12, 2026
Merged

chore: sync AGENTS.md, agent definitions, standards, and lint scripts from TemplateDotNetTool#94
Malcolmnixon merged 1 commit intomainfrom
copilot/binary-copy-updated-files

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

Pull Request

Description

Binary-copies updated files from the TemplateDotNetTool template into this repository. No content modifications — straight overwrites.

Files updated:

  • AGENTS.md — references two new standards files; updates agent delegation guidance
  • .github/agents/*.md — all 5 agent definitions refreshed
  • .github/standards/*.md — 7 existing standards updated; 2 new files added:
    • coding-principles.md — universal literate coding and architecture principles
    • testing-principles.md — universal test dependency boundary and AAA pattern standards
  • lint.sh / lint.bat — updated linting scripts

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

These are documentation/agent-config files only. No source code, tests, or build configuration was changed.

@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 12, 2026 01:37
Copilot AI review requested due to automatic review settings April 12, 2026 01:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs agent/standards documentation and linting entrypoints from the TemplateDotNetTool template into SarifMark to keep repo governance docs and lint workflow aligned with the shared baseline.

Changes:

  • Expanded lint.sh / lint.bat to restore dotnet tools and run reqstream, versionmark, and reviewmark lint steps; added PUPPETEER_SKIP_DOWNLOAD.
  • Updated AGENTS.md and refreshed standards docs (added coding-principles.md + testing-principles.md, added front-matter metadata, clarified/reshaped several standards).
  • Updated the quality agent checklist to include hierarchy boundary checks for tests and reorganized Result guidance.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lint.sh Adds Puppeteer skip-download and dotnet-tool-based linting (ReqStream/VersionMark/ReviewMark) plus dotnet format --no-restore.
lint.bat Windows equivalent of the updated lint workflow with clearer section abort handling and added dotnet tool linting.
AGENTS.md Updates repo tree placeholders and references the two new standards files.
.github/standards/testing-principles.md Introduces universal testing principles (hierarchy boundaries + AAA).
.github/standards/coding-principles.md Introduces universal coding principles (literate coding + architecture gates).
.github/standards/technical-documentation.md Adds front matter and clarifies “References” section constraints.
.github/standards/software-items.md Adds front matter and clarifies subsystem/unit definitions.
.github/standards/reviewmark-usage.md Adds front matter and “Required Standards” prerequisite section.
.github/standards/reqstream-usage.md Adds front matter, prerequisites, and clarifies downward-only linking language.
.github/standards/design-documentation.md Adds front matter/prerequisites and updates Scope guidance.
.github/standards/csharp-testing.md Adds front matter/prerequisites and re-scopes AAA guidance.
.github/standards/csharp-language.md Adds front matter/prerequisites and focuses on formatting + XmlDoc quality checks.
.github/agents/quality.agent.md Adds hierarchy boundary checklist items and relocates Result guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/standards/design-documentation.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants