chore: align with TemplateDotNetTool template (PRs #66, #72–#76, #80) by Copilot · Pull Request #83 · demaconsulting/SarifMark

Copilot · 2026-03-31T02:32:54Z

Pull Request

Description

Syncs SarifMark with recent TemplateDotNetTool template evolution, verified against the 20 most recently merged template PRs.

New agent files

developer.agent.md — standards-based general-purpose development agent
implementation.agent.md — orchestrator with RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine
quality.agent.md — quality assurance grading agent

Updated agent files

code-review.agent.md — exact copy from template (step 4 wording matches template verbatim)
repo-consistency.agent.md — exact copy from template

Removed legacy agent files

The following agent files have been removed as they were removed from the TemplateDotNetTool template:

code-quality.agent.md
requirements.agent.md
software-developer.agent.md
technical-writer.agent.md
test-developer.agent.md

New standards reference files (`.github/standards/`)

Six files covering C# language, C# testing, reqstream usage, reviewmark usage, software items, and technical documentation — exact copies from the TemplateDotNetTool template (verified by blob SHA).

`AGENTS.md`

Template sections copied verbatim in the same order as the TemplateDotNetTool template: Standards Application, Agent Delegation Guidelines, Available Specialized Agents, Quality Gate Enforcement, Continuous Compliance Overview, Required Compliance Tools, Project Structure Template, Key Configuration Files, Continuous Compliance Workflow, Continuous Compliance Requirements, Agent Report Files
SarifMark-specific sections appended after the template content: Tech Stack, Testing, Code Style, Markdown Link Style, Build & Quality, Custom Agents, Agent Selection Guide

Lint scripts

lint.sh — added --silent/--quiet/--disable-pip-version-check flags to suppress noise
lint.bat — rewritten to accumulate all linter failures before exiting (matches template pattern)

Config / workflow

.cspell.yaml, .markdownlint-cli2.yaml, .gitignore — exclude .agent-logs/ directory
build.yaml — bumped Node to 24.x; removed redundant --definition .reviewmark.yaml from ReviewMark step
.reviewmark.yaml — added docs/design/**/*.md to needs-review patterns

Docs folder rename

docs/guide/ renamed to docs/user_guide/ and guide.md renamed to introduction.md
Updated all references in build.yaml (step names, --defaults, --output, Weasyprint input) and docs/user_guide/definition.yaml

Skipped: dependabot bumps (handled by SarifMark's own Dependabot), and template-specific source folder restructuring.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

Code builds successfully: dotnet build --configuration Release
All unit tests pass: dotnet test --configuration Release
Self-validation tests pass:
dotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0
--no-build -- --validate
Code produces zero warnings

Code Quality

Code formatting is correct: dotnet format --verify-no-changes
New code has appropriate XML documentation comments
Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

Added unit tests for new functionality
Updated existing tests if behavior changed
All tests follow the AAA (Arrange, Act, Assert) pattern
Test coverage is maintained or improved

Documentation

Updated README.md (if applicable)
Updated ARCHITECTURE.md (if applicable)
Added code examples for new features (if applicable)
Updated requirements.yaml (if applicable)

Additional Notes

No production code or tests were modified. All changes are to agent definitions, standards references, lint scripts, CI/repo config, and documentation folder structure.

Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/8d9bc3e5-e4ae-45e3-b4f6-8f1e5919cf0b Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot

Pull request overview

Aligns SarifMark’s repo hygiene, CI, and Copilot agent/standards collateral with recent TemplateDotNetTool template updates, mainly affecting agent guidance, lint scripts, and documentation/build automation.

Changes:

Added new Copilot agent definitions and standards reference docs under .github/agents/ and .github/standards/.
Updated lint scripts/config to reduce output noise and ignore .agent-logs/.
Updated CI to use Node 24.x for quality checks and to generate Design HTML/PDF documentation artifacts.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`lint.sh`	Quieter npm/pip/cspell output in Unix lint flow.
`lint.bat`	Reworked Windows lint flow to accumulate failures and run all linters.
`AGENTS.md`	Adds standards/delegation guidance and updates agent reporting path conventions to `.agent-logs/`.
`.reviewmark.yaml`	Expands `needs-review` to include `docs/design/*/.md`.
`.markdownlint-cli2.yaml`	Disables banner/progress and ignores `.agent-logs/`.
`.gitignore`	Ignores `.agent-logs/` directory.
`.github/workflows/build.yaml`	Sets Node 24.x for quality-checks; adds Design HTML/PDF generation; removes explicit ReviewMark definition arg.
`.cspell.yaml`	Ignores `.agent-logs/`.
`.github/standards/csharp-language.md`	New C# language standards reference for agents.
`.github/standards/csharp-testing.md`	New MSTest standards reference for agents.
`.github/standards/reqstream-usage.md`	New ReqStream usage standards reference for agents.
`.github/standards/reviewmark-usage.md`	New ReviewMark usage standards reference for agents.
`.github/standards/software-items.md`	New software item categorization standards reference for agents.
`.github/standards/technical-documentation.md`	New technical documentation standards reference for agents.
`.github/agents/code-review.agent.md`	Updates formal review agent instructions and reporting location.
`.github/agents/repo-consistency.agent.md`	Refreshes template consistency workflow and reporting guidance.
`.github/agents/developer.agent.md`	Adds general-purpose developer agent definition.
`.github/agents/implementation.agent.md`	Adds orchestration agent with RESEARCH→DEVELOPMENT→QUALITY→REPORT workflow.
`.github/agents/quality.agent.md`	Adds quality grading/assessment agent definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lint.sh

lint.bat

.github/workflows/build.yaml

.github/standards/technical-documentation.md

.github/agents/code-review.agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Malcolmnixon · 2026-03-31T11:51:49Z

@copilot Please rename the docs/guide to docs/user_guide and its guide.md to introduction.md

…on.md Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/2fcc24c8-25e2-4d47-91b3-318e14ffb6d1 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-31T11:55:12Z

@copilot Please rename the docs/guide to docs/user_guide and its guide.md to introduction.md

Done in commit 51160fd. Renamed docs/guide/ → docs/user_guide/ and guide.md → introduction.md, and updated all references in build.yaml (step names, --defaults, --output, and Weasyprint input paths) and docs/user_guide/definition.yaml.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Malcolmnixon · 2026-03-31T13:12:10Z

@copilot There are legacy agents still in the .github/agents folder which have been removed from the template. Please update.

Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/0162c9bb-1dbc-457e-b5ce-b1b2600688e3 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-31T13:16:54Z

@copilot There are legacy agents still in the .github/agents folder which have been removed from the template. Please update.

Done in commit ad78efd. Removed the 5 legacy agent files that are no longer in the template (code-quality.agent.md, requirements.agent.md, software-developer.agent.md, technical-writer.agent.md, test-developer.agent.md) and updated AGENTS.md to remove all references to them from the Available Specialized Agents, Agent Selection Guide, and Custom Agents sections, mapping those tasks to the current template agents (@developer, @implementation, @quality).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Malcolmnixon · 2026-03-31T13:22:14Z

@copilot Make sure to match the templates AGENTS.md

Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/510afeec-654d-468a-9da0-532e2bdfbb21 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-31T13:28:09Z

@copilot Make sure to match the templates AGENTS.md

Done in commit 3718e13. AGENTS.md now matches the template structure: added the missing sections (Quality Gate Enforcement, Continuous Compliance Overview, Required Compliance Tools, Project Structure Template, Key Configuration Files, Continuous Compliance Workflow, Continuous Compliance Requirements) in the template's order, with the Available Specialized Agents descriptions matching the template's multi-line format. The SarifMark-specific sections (Tech Stack, Testing, Code Style, Markdown Link Style, Build & Quality, Custom Agents, Agent Selection Guide) are retained after the template sections. The Test Source Filters content is now under Continuous Compliance Requirements, and the spell check word list policy is under Key Configuration Files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Malcolmnixon · 2026-03-31T13:31:50Z

@copilot You pulled in new sections for AGENTS.md from the template; but I think it would be better to just make sure you COPY the AGENTS.md, .github/agents/.md and .github/standards/.md

Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/3f6495f1-09cd-4ab3-9809-0fba0a28ef78 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-31T13:41:45Z

@copilot You pulled in new sections for AGENTS.md from the template; but I think it would be better to just make sure you COPY the AGENTS.md, .github/agents/.md and .github/standards/.md

Done in commit fbcb8bf. All .github/agents/*.md and .github/standards/*.md files were verified against the template's blob SHAs — they already matched exactly. The only change needed was reverting code-review.agent.md step 4 back to the template's exact wording (a previous commit had improved the phrasing). AGENTS.md is structured with the template's sections verbatim, followed by SarifMark-specific additions (Tech Stack, Testing, Code Style, Markdown Link Style, Build & Quality, Custom Agents, Agent Selection Guide).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

992ebac

Copilot AI assigned Copilot and Malcolmnixon Mar 31, 2026

Copilot started work on behalf of Malcolmnixon March 31, 2026 02:32 View session

Copilot AI changed the title ~~[WIP] Run repo consistency agent for template updates~~ chore: align with TemplateDotNetTool template (PRs #66, #72–#76, #80) Mar 31, 2026

Copilot finished work on behalf of Malcolmnixon March 31, 2026 02:59

Copilot AI requested a review from Malcolmnixon March 31, 2026 02:59

Malcolmnixon marked this pull request as ready for review March 31, 2026 10:22

Copilot AI review requested due to automatic review settings March 31, 2026 10:22

Copilot started reviewing on behalf of Malcolmnixon March 31, 2026 10:23 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Malcolmnixon and others added 2 commits March 31, 2026 07:50

Update .github/workflows/build.yaml

9c78b6b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/agents/code-review.agent.md

bdb3376

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of Malcolmnixon March 31, 2026 11:51 View session

Copilot finished work on behalf of Malcolmnixon March 31, 2026 11:56

Malcolmnixon approved these changes Mar 31, 2026

View reviewed changes

Copilot started work on behalf of Malcolmnixon March 31, 2026 13:12 View session

Copilot finished work on behalf of Malcolmnixon March 31, 2026 13:19

Copilot AI requested a review from Malcolmnixon March 31, 2026 13:19

Malcolmnixon approved these changes Mar 31, 2026

View reviewed changes

Copilot started work on behalf of Malcolmnixon March 31, 2026 13:23 View session

Copilot finished work on behalf of Malcolmnixon March 31, 2026 13:29

Copilot AI requested a review from Malcolmnixon March 31, 2026 13:29

Copilot started work on behalf of Malcolmnixon March 31, 2026 13:31 View session

Copilot finished work on behalf of Malcolmnixon March 31, 2026 13:44

Malcolmnixon merged commit 085ad13 into main Mar 31, 2026
15 checks passed

Malcolmnixon deleted the copilot/run-repo-consistency-agent branch March 31, 2026 14:05

Conversation

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Description

New agent files

Updated agent files

Removed legacy agent files

New standards reference files (.github/standards/)

AGENTS.md

Lint scripts

Config / workflow

Docs folder rename

Type of Change

Related Issues

Pre-Submission Checklist

Build and Test

Code Quality

Quality Checks

Testing

Documentation

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Malcolmnixon commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Malcolmnixon commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Malcolmnixon commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Malcolmnixon commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 31, 2026 •

edited

Loading

New standards reference files (`.github/standards/`)

`AGENTS.md`

Copilot AI commented Mar 31, 2026 •

edited

Loading

Copilot AI commented Mar 31, 2026 •

edited

Loading

Copilot AI commented Mar 31, 2026 •

edited

Loading

Copilot AI commented Mar 31, 2026 •

edited

Loading