Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63, #64)#77
Conversation
|
@copilot please fix ".github/agents/technical-writer.agent.md:38:121 error MD013/line-length Line length [Expected: 120; Actual: 130]" |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the SarifMark template repository to reflect recent agent, linting, and CI workflow conventions, consolidating quality checks into a single cross-tool lint script and migrating lint configuration formats.
Changes:
- Standardize agent file naming/frontmatter and update agent guidance to “Subagent Delegation” with
@agentnotation. - Migrate lint configurations from JSON/JSONC to YAML and add policy/standards documentation in
AGENTS.md. - Rework CI “Quality Checks” to run
bash ./lint.sh, and update local lint scripts + supporting files (pip-requirements.txt,.gitignore).
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pip-requirements.txt |
Adds pinned Python dependency for yamllint installs. |
lint.sh |
Replaces simple linter invocations with a comprehensive script that installs dependencies and aggregates failures. |
lint.bat |
Updates Windows lint invocation to align (partially) with the new linting approach. |
CONTRIBUTING.md |
Updates documentation references for new agent glob and .cspell.yaml format. |
AGENTS.md |
Updates agent naming, delegation guidance, and adds spell-check/link-style policies. |
.yamllint.yaml |
Adds header/standards text and ignore list updates. |
.markdownlint-cli2.yaml |
Introduces YAML-based markdownlint-cli2 config with ignores and rule settings. |
.markdownlint-cli2.jsonc |
Removes old JSONC markdownlint configuration. |
.gitignore |
Adds .venv/ to ignore Python virtual environments. |
.github/workflows/build.yaml |
Switches quality checks to bash ./lint.sh and adds Node/Python setup steps. |
.github/pull_request_template.md |
Removes duplicate self-validation checklist item. |
.github/agents/test-developer.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section. |
.github/agents/technical-writer.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section. |
.github/agents/software-developer.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section. |
.github/agents/requirements.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section. |
.github/agents/repo-consistency.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section and references. |
.github/agents/code-review.agent.md |
Renames agent + adds tools: frontmatter. |
.github/agents/code-quality.agent.md |
Renames agent + adds tools: frontmatter + updates delegation section and references. |
.cspell.yaml |
Introduces YAML-based cspell configuration with expanded ignorePaths and documented policy. |
.cspell.json |
Removes old JSON-based cspell configuration. |
Comments suppressed due to low confidence (1)
lint.bat:14
lint.batstill assumesyamllintis already available on PATH, butlint.shnow provisions it via a Python venv +pip-requirements.txt. To keep Windows linting usable and consistent with CI, consider adding the equivalent venv/pip install steps (or otherwise ensuringyamllintis installed before invoking it).
echo Checking spelling...
call npx cspell --no-progress --no-color "**/*.{cs,md,json,yaml,yml,txt}"
if %errorlevel% neq 0 exit /b %errorlevel%
echo Checking YAML...
call yamllint -c .yamllint.yaml .
if %errorlevel% neq 0 exit /b %errorlevel%
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot There have been a few more pull requests to the template. Please bring those in as well |
…mpliance templates Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/efb11e44-548f-4090-b0a4-cb10605f5c38
Applied TemplateDotNetTool PR #64 ("Align lint YAML configs with ContinuousCompliance templates") in f0d8571. Changes:
That was the only new merged PR since #63 in the template. |
Propagates four batches of improvements from the TemplateDotNetTool template (PRs #61, #62, #63, #64) to bring SarifMark back in sync.
Agent files (
.github/agents/).agent.mddouble-extension convention (e.g.code-quality-agent.md→code-quality.agent.md)tools:field and lowercasedname:in frontmatter for all 7 filescall the @agent-name agent with the **request** to... and the **context** of...patternAGENTS.md@agent-namenotationLinting configuration
.cspell.json→.cspell.yaml: adds header,Propagatable/versionmarkwords,/**glob suffixes on ignore paths,.venv/**; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to double-star globs (**/.git/**,**/bin/**, etc.), addedthirdparty/third-party/3rd-partyexclusions, removed file-extension patterns (*.nupkg,*.dll,*.trx, etc.) andyarn.lock.markdownlint-cli2.jsonc→.markdownlint-cli2.yaml: adds header,.venvignore; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to full double-star pattern set with.gitand thirdparty exclusions.yamllint.yaml: adds header,ignore:block fornode_modules//.git//.venv/, removescheck-keys: true; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to reorder.git/first and addthirdparty//third-party//3rd-party/entriespip-requirements.txtpinningyamllint==1.38.0Linting scripts & CI
lint.shrewritten:lint_erroraccumulation (all failures reported),--no-coloron cspell (PR Bump actions/download-artifact from 7 to 8 #62), Python venv setup,npm installlint.bat: adds--no-colorto cspellbuild.yamlquality-checks job: adds Node.js 24.x + Python 3.14 setup steps; replaces three individual lint GitHub Actions withbash ./lint.sh(CI now uses identical command as local dev)Polish
.gitignore: adds.venv/CONTRIBUTING.md: updates agent file glob and cspell config filenameType of Change
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
No production code or tests were changed. All changes are to agent definitions, linting configuration, CI workflows, and developer tooling. CodeQL scan returned 0 alerts.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.