Skip to content

Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63, #64)#77

Merged
Malcolmnixon merged 6 commits intomainfrom
copilot/update-template-repository
Mar 21, 2026
Merged

Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63, #64)#77
Malcolmnixon merged 6 commits intomainfrom
copilot/update-template-repository

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

Propagates four batches of improvements from the TemplateDotNetTool template (PRs #61, #62, #63, #64) to bring SarifMark back in sync.

Agent files (.github/agents/)

  • Renamed all 7 files to .agent.md double-extension convention (e.g. code-quality-agent.mdcode-quality.agent.md)
  • Added tools: field and lowercased name: in frontmatter for all 7 files
  • Replaced "Defer To" bullet lists with "Subagent Delegation" sections using call the @agent-name agent with the **request** to... and the **context** of... pattern

AGENTS.md

  • Updated agent list and selection guide to use @agent-name notation
  • Added Spell check word list policy subsection (PR Bump the nuget-dependencies group with 1 update #63): never add misspelled words to the word list
  • Added Markdown Link Style section documenting inline vs reference-style link rules per file type
  • Updated key file references to new config names

Linting configuration

  • .cspell.json.cspell.yaml: adds header, Propagatable/versionmark words, /** glob suffixes on ignore paths, .venv/**; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to double-star globs (**/.git/**, **/bin/**, etc.), added thirdparty/third-party/3rd-party exclusions, removed file-extension patterns (*.nupkg, *.dll, *.trx, etc.) and yarn.lock
  • .markdownlint-cli2.jsonc.markdownlint-cli2.yaml: adds header, .venv ignore; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to full double-star pattern set with .git and thirdparty exclusions
  • .yamllint.yaml: adds header, ignore: block for node_modules//.git//.venv/, removes check-keys: true; then updated (PR Fix dependabot config to group GitHub Actions updates #64) to reorder .git/ first and add thirdparty//third-party//3rd-party/ entries
  • New pip-requirements.txt pinning yamllint==1.38.0

Linting scripts & CI

  • lint.sh rewritten: lint_error accumulation (all failures reported), --no-color on cspell (PR Bump actions/download-artifact from 7 to 8 #62), Python venv setup, npm install
  • lint.bat: adds --no-color to cspell
  • build.yaml quality-checks job: adds Node.js 24.x + Python 3.14 setup steps; replaces three individual lint GitHub Actions with bash ./lint.sh (CI now uses identical command as local dev)

Polish

  • .gitignore: adds .venv/
  • CONTRIBUTING.md: updates agent file glob and cspell config filename
  • PR template: removes duplicate self-validation entry from Quality Checks section

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No production code or tests were changed. All changes are to agent definitions, linting configuration, CI workflows, and developer tooling. CodeQL scan returned 0 alerts.


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…, #63

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 20, 2026 01:44
Copilot AI review requested due to automatic review settings March 20, 2026 01:44
Copilot AI changed the title [WIP] Update template repository with recent changes Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63) Mar 20, 2026
@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot please fix ".github/agents/technical-writer.agent.md:38:121 error MD013/line-length Line length [Expected: 120; Actual: 130]"

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 20, 2026

@copilot please fix ".github/agents/technical-writer.agent.md:38:121 error MD013/line-length Line length [Expected: 120; Actual: 130]"

Fixed in a614e31 — wrapped the line at 120 characters by splitting it across two lines.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SarifMark template repository to reflect recent agent, linting, and CI workflow conventions, consolidating quality checks into a single cross-tool lint script and migrating lint configuration formats.

Changes:

  • Standardize agent file naming/frontmatter and update agent guidance to “Subagent Delegation” with @agent notation.
  • Migrate lint configurations from JSON/JSONC to YAML and add policy/standards documentation in AGENTS.md.
  • Rework CI “Quality Checks” to run bash ./lint.sh, and update local lint scripts + supporting files (pip-requirements.txt, .gitignore).

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pip-requirements.txt Adds pinned Python dependency for yamllint installs.
lint.sh Replaces simple linter invocations with a comprehensive script that installs dependencies and aggregates failures.
lint.bat Updates Windows lint invocation to align (partially) with the new linting approach.
CONTRIBUTING.md Updates documentation references for new agent glob and .cspell.yaml format.
AGENTS.md Updates agent naming, delegation guidance, and adds spell-check/link-style policies.
.yamllint.yaml Adds header/standards text and ignore list updates.
.markdownlint-cli2.yaml Introduces YAML-based markdownlint-cli2 config with ignores and rule settings.
.markdownlint-cli2.jsonc Removes old JSONC markdownlint configuration.
.gitignore Adds .venv/ to ignore Python virtual environments.
.github/workflows/build.yaml Switches quality checks to bash ./lint.sh and adds Node/Python setup steps.
.github/pull_request_template.md Removes duplicate self-validation checklist item.
.github/agents/test-developer.agent.md Renames agent + adds tools: frontmatter + updates delegation section.
.github/agents/technical-writer.agent.md Renames agent + adds tools: frontmatter + updates delegation section.
.github/agents/software-developer.agent.md Renames agent + adds tools: frontmatter + updates delegation section.
.github/agents/requirements.agent.md Renames agent + adds tools: frontmatter + updates delegation section.
.github/agents/repo-consistency.agent.md Renames agent + adds tools: frontmatter + updates delegation section and references.
.github/agents/code-review.agent.md Renames agent + adds tools: frontmatter.
.github/agents/code-quality.agent.md Renames agent + adds tools: frontmatter + updates delegation section and references.
.cspell.yaml Introduces YAML-based cspell configuration with expanded ignorePaths and documented policy.
.cspell.json Removes old JSON-based cspell configuration.
Comments suppressed due to low confidence (1)

lint.bat:14

  • lint.bat still assumes yamllint is already available on PATH, but lint.sh now provisions it via a Python venv + pip-requirements.txt. To keep Windows linting usable and consistent with CI, consider adding the equivalent venv/pip install steps (or otherwise ensuring yamllint is installed before invoking it).
echo Checking spelling...
call npx cspell --no-progress --no-color "**/*.{cs,md,json,yaml,yml,txt}"
if %errorlevel% neq 0 exit /b %errorlevel%

echo Checking YAML...
call yamllint -c .yamllint.yaml .
if %errorlevel% neq 0 exit /b %errorlevel%

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Malcolmnixon and others added 2 commits March 19, 2026 21:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot There have been a few more pull requests to the template. Please bring those in as well

…mpliance templates

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/demaconsulting/SarifMark/sessions/efb11e44-548f-4090-b0a4-cb10605f5c38
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 20, 2026

@copilot There have been a few more pull requests to the template. Please bring those in as well

Applied TemplateDotNetTool PR #64 ("Align lint YAML configs with ContinuousCompliance templates") in f0d8571. Changes:

  • .cspell.yaml: Switched ignorePaths to double-star globs (**/.git/**, **/node_modules/**, etc.); added thirdparty/third-party/3rd-party exclusions; removed file-extension patterns (*.nupkg, *.dll, *.trx, etc.) and yarn.lock
  • .markdownlint-cli2.yaml: Expanded ignores to full double-star pattern set; added .git and thirdparty exclusions
  • .yamllint.yaml: Reordered .git/ before node_modules/; added thirdparty/, third-party/, 3rd-party/ to ignore block

That was the only new merged PR since #63 in the template.

Copilot AI changed the title Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63) Apply recent template updates from TemplateDotNetTool (PRs #61, #62, #63, #64) Mar 20, 2026
@Malcolmnixon Malcolmnixon merged commit ce469d1 into main Mar 21, 2026
15 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/update-template-repository branch March 21, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants