Apply TemplateDotNetTool consistency updates to SarifMark#60
Merged
Malcolmnixon merged 2 commits intomainfrom Mar 1, 2026
Merged
Apply TemplateDotNetTool consistency updates to SarifMark#60Malcolmnixon merged 2 commits intomainfrom
Malcolmnixon merged 2 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Check for updates from the template
Apply TemplateDotNetTool consistency updates to SarifMark
Mar 1, 2026
Malcolmnixon
approved these changes
Mar 1, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs SarifMark with recent TemplateDotNetTool template commits. Covers package upgrades, null safety guards, and agent documentation gaps.
Description
Project / Package Updates
LangVersion:12→latest(both csproj files)GenerateDocumentationFile:True→true(casing consistency)SonarAnalyzer.CSharp:10.19.0.132793→10.20.0.135146(both csproj files)Microsoft.NET.Test.Sdk:18.0.1→18.3.0(test csproj)Polyfill9.12.0 (source-only, main csproj) — enablesArgumentNullException.ThrowIfNullon all target frameworks<Using Include="Polyfills" />implicit global using (test csproj)PrivateAssets/IncludeAssetsPackageReference groupsNull Guards
Added
ArgumentNullException.ThrowIfNullguards in three entry points:Agent Documentation
test-developer.md: Added MSTest anti-pattern Add ToMarkdown method to SarifResults for markdown export #5 — preferAssert.StartsWithoverAssert.IsTrue(value.StartsWith(...))requirements-agent.md: Added "Test Source Filters" section documentingwindows@,ubuntu@,net8.0@,dotnet9.x@, etc. prefixescode-quality-agent.md: Fixed markdownlint config filename (.markdownlint.json→.markdownlint-cli2.jsonc)AGENTS.md: Added "Test Source Filters" quick-reference sectionType of Change
Pre-Submission Checklist
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint '**/*.{yml,yaml}'dotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0 --no-build -- --validateTesting
Documentation
Additional Notes
Polyfillmust not be added as a directPackageReferencein the test project — since the test project usesProjectReferenceto the main project, adding it to both causes duplicate contentfile compilation (CS0121 ambiguous method errors on net8/net9). The implicit using alone is sufficient.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.