Skip to content

Fix lint scripts: yamllint is Python, not Node#43

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-lint-scripts-functionality
Jan 28, 2026
Merged

Fix lint scripts: yamllint is Python, not Node#43
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-lint-scripts-functionality

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Pull Request

Description

The lint scripts were invoking npx yamllint, which fails because yamllint is a Python package distributed via PyPI, not an npm package. Updated both scripts to call yamllint directly with explicit config file reference.

Changes:

  • lint.sh: Changed from npx yamllint . to yamllint -c .yamllint.yaml .
  • lint.bat: Changed from npx yamllint . to yamllint -c .yamllint.yaml .

This aligns with the CI workflow which uses ibiqlik/action-yamllint@v3 to install and run the Python-based yamllint.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No application code changes. Shell scripts only. Yamllint must be pre-installed in the environment (via pip/pipx).

Original prompt

Can you make sure the lint scripts in the root are functional - I believe yamllint is python not node, and so can't be run under npx.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix lint scripts to ensure functionality Fix lint scripts: yamllint is Python, not Node Jan 28, 2026
Copilot AI requested a review from Malcolmnixon January 28, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants