Fix documentation accuracy and test parallelization issues#31
Fix documentation accuracy and test parallelization issues#31Malcolmnixon merged 6 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
|
@copilot Did you check the guide for accuracy - it mentions the results may include code snippets. Is that true? |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
You're correct - the guide incorrectly claimed results include code snippets and remediation guidance. The tool only extracts and displays: file location, line number, severity level, rule ID, and issue message. Fixed in commit db1fe8c. |
|
@copilot The PR is encountering intermittent failures. I don't believe the tests are safe to run in parallel if they're capturing console output. Please disable all parallelization if stdout capturing is being used. |
…e output capturing Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Fixed in commit 525a654. Changed test parallelization from 4 workers to 1 worker (sequential execution) to prevent race conditions when capturing console output. Verified with 5 consecutive test runs - all passed. |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
* Initial plan * Apply template updates from PRs #31-#51 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Apply semantic requirement IDs from template PR #50 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Pull Request
Description
This PR addresses technical documentation inaccuracies and fixes intermittent test failures caused by parallel execution.
Changes to README.md:
**Results:** 2line that never appears in generated markdown reports (only in console output)warning TEST001:towarning [TEST001]to match actual code behaviorChanges to docs/guide/guide.md:
Changes to test/DemaConsulting.SarifMark.Tests/AssemblyInfo.cs:
[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]to[assembly: DoNotParallelize]Console.Out(a global resource), causing race conditions when run in parallelBefore (README.md):
After (README.md):
Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint '**/*.{yml,yaml}'Testing
Documentation
Additional Notes
Verified with actual tool execution that generated markdown matches the updated documentation. Tested all command-line options mentioned in the guide (--report-depth, --heading, --enforce, --validate, --results) to ensure documentation accuracy.
Test Stability: Disabled test parallelization using
[assembly: DoNotParallelize]attribute. Ran tests 5 consecutive times to verify elimination of intermittent failures. All 62 tests pass consistently with sequential execution.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.