Fix SonarCloud coverage report glob pattern and update devDependencies - #137
Merged
Merged
Conversation
SonarCloud reports zero code coverage for this repo. This project uses xunit.v3 4.0.0, which only runs under the Microsoft.Testing.Platform (MTP) 'dotnet test' mode, so the test project correctly uses coverlet.MTP (the VSTest-only coverlet.collector doesn't work under MTP). However, coverlet.MTP names its output file coverage.opencover.<numeric-session-id>.xml, whereas the workflow's Sonar scanner argument used the glob **/*.opencover.xml, which only matches filenames literally ending in "opencover.xml" - the session-ID segment breaks that match, so the scanner silently found no coverage report to ingest. Verified locally: `dotnet test --coverlet --coverlet-output-format opencover` (matching CI) produces files such as coverage.opencover.280826204313894.xml, which the corrected glob **/coverage.opencover.*.xml matches but the old glob did not. All 606 tests still pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Updates direct npm devDependencies to their latest published versions: @mermaid-js/mermaid-cli 11.12.0 -> 11.16.0, cspell 9.7.0 -> 10.1.1, markdownlint-cli2 0.21.0 -> 0.23.2 (mermaid-filter already at latest 1.4.7). Remaining npm audit findings are transitive dependencies pulled in via mermaid-cli/mermaid-filter's puppeteer dependency, with no fix currently available upstream - out of scope per user request. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Node-based development tooling versions and adjusts the SonarCloud OpenCover report glob in the CI workflow to better match the coverage reports produced during test runs.
Changes:
- Bumped devDependencies in
package.json(@mermaid-js/mermaid-cli,cspell,markdownlint-cli2). - Updated the SonarCloud OpenCover reports path glob in
.github/workflows/build.yamlto**/coverage.opencover.*.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates pinned dev tool versions used by CI/local linting and diagram generation. |
| .github/workflows/build.yaml | Adjusts SonarCloud coverage report discovery glob for OpenCover XML outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates development dependencies and modifies the SonarCloud report path in the build workflow to improve compatibility and maintainability.
Dependency updates:
@mermaid-js/mermaid-clifrom version 11.12.0 to 11.16.0 inpackage.jsonto include the latest features and fixes.cspellfrom 9.7.0 to 10.1.1 andmarkdownlint-cli2from 0.21.0 to 0.23.2 inpackage.jsonfor improved linting and spell-checking capabilities.Build workflow improvements:
.github/workflows/build.yamlto match files with the pattern**/coverage.opencover.*.xml, ensuring more accurate report discovery.