Suppress context files under review in elaboration output#81
Merged
Conversation
…n output When a file appears in both the context: list and the paths: list for a given review set, it is suppressed from the Context subsection and shown only in the Files subsection. This prevents the same file from being presented with contradictory purpose in a single elaboration output. - Update ElaborateReviewSet() to subtract files-under-review from context - Add requirement ReviewMark-Config-ContextDeduplication - Add design note for the deduplication step - Add tests for suppression and non-suppression cases - Add verification entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…n output When a file appears in both the context: list and the paths: list for a given review set, it is suppressed from the Context subsection and shown only in the Files subsection. This prevents the same file from being presented with contradictory purpose in a single elaboration output. - Update ElaborateReviewSet() to subtract files-under-review from context - Add requirement ReviewMark-Config-ContextDeduplication - Add design note for the deduplication step - Add tests for suppression and non-suppression cases - Add verification entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ReviewMark’s configuration elaboration output so that any file that is both (a) under review via a review set’s paths: and (b) matched by context: is shown only under Files and suppressed from Context, preventing the same file from being presented with two purposes in one elaboration.
Changes:
- Updated
ElaborateReviewSetto resolve files-under-review first and filter overlapping context entries out of the Context subsection. - Added unit tests covering suppression when a file is in both context and paths, and non-suppression when a context file is not in paths.
- Documented and requirements-tracked the new deduplication rule (design + verification + reqstream requirement).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DemaConsulting.ReviewMark.Tests/Configuration/ReviewMarkConfigurationTests.cs | Adds tests validating context-vs-files suppression behavior in elaboration output. |
| src/DemaConsulting.ReviewMark/Configuration/ReviewMarkConfiguration.cs | Implements context suppression for files that are also under review in the same review set. |
| docs/verification/review-mark/configuration/review-mark-configuration.md | Documents verification coverage for the new requirement and the added tests. |
| docs/reqstream/review-mark/configuration/review-mark-configuration.yaml | Adds a new requirement describing the context deduplication/suppression behavior. |
| docs/design/review-mark/configuration/review-mark-configuration.md | Updates design documentation to describe the new suppression rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements and documents a new deduplication rule for context files in the ReviewMark configuration system. Now, when a file appears in both the
context:list and a review set'spaths:list, it is shown only in theFilessubsection and suppressed from theContextsubsection in the elaboration output. This ensures each file's purpose is clear and avoids conflicting guidance. The change is fully documented, requirements-tracked, and tested.Deduplication logic and implementation:
ElaborateReviewSetinReviewMarkConfiguration.csto resolve files-under-review first and suppress any overlapping files from the Context subsection, ensuring a file cannot serve both purposes in the same output.ElaborateReviewSetto reflect the new deduplication behavior.Documentation and requirements:
ReviewMark-Config-ContextDeduplication) to the requirements YAML, specifying that files present in both context and paths are only shown in the Files list, with justification and test references.Testing: