Fix for puppeteer/chrome.#72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows “Build Documents” GitHub Actions job to avoid Puppeteer downloading Chromium during npm install and instead rely on an installed browser executable path for Mermaid rendering.
Changes:
- Set
PUPPETEER_SKIP_DOWNLOAD=truefor the npm install step in the docs build job. - Add a PowerShell step to populate
PUPPETEER_EXECUTABLE_PATHon Windows runners. - Minor formatting adjustment in the “Capture tool versions” command list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Malcolmnixon
pushed a commit
to demaconsulting/TemplateDotNetTool
that referenced
this pull request
Jun 24, 2026
Skip Puppeteer's bundled Chromium download (PUPPETEER_SKIP_DOWNLOAD=true) and instead locate the system-installed Chrome on Windows runners, matching the fix applied in demaconsulting/ReviewMark#72. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Malcolmnixon
added a commit
to demaconsulting/TemplateDotNetTool
that referenced
this pull request
Jun 24, 2026
* Sync template structure: introductions, reviewmark context and reviews - docs/design/introduction.md: rewrite Scope with Local/OTS grouping and correct out-of-scope wording; fix Folder Layout to folders-only under src/ - docs/verification/introduction.md: rewrite Scope with Local/OTS grouping and correct out-of-scope wording; add Folder Layout (test/ folders only); add References section - .reviewmark.yaml: add global context (docs/design/introduction.md); add Decomposition review; fix Purpose to exclude design introduction via local context override; fix Architecture paths to include verification introduction; add per-review context blocks to all system, subsystem, and unit reviews; fix AllRequirements and Design paths per standard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address formal review findings from Purpose/Decomposition/Specials - README.md: add ## Contributing section linking to CONTRIBUTING.md - docs/user_guide/introduction.md: add ## References section (N/A) - docs/design/introduction.md: add OTS items to Software Structure and Companion Artifact Structure; fix References to document name + URL - docs/reqstream/template-dot-net-tool/template-dot-net-tool.yaml: reword Template-System-ValidateFailure to match linked test evidence (non-zero on results write error, not self-validation test failure) - docs/reqstream/template-dot-net-tool/platform-requirements.yaml: reword compound build+run requirements as single observable criteria - docs/design/template-dot-net-tool/**/*.md: recreate all 8 design docs with correct heading depths and mandatory sections (Dependencies, Risk Control Measures, Design, Purpose, Key Methods, Error Handling, Callers) - docs/verification/template-dot-net-tool/**/*.md: recreate all 8 verification docs with correct heading depths and mandatory sections (Verification Approach, Test Environment, Acceptance Criteria) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: apply formal-review findings from full 23-set review - Reword Template-System-DefaultBehavior as sequential (then, not and) - Split Template-OTS-ReviewMark-Operations into Lint/Elaborate/Enforce - Add Template-SelfTest-InvalidExtension requirement - Add Template-Validation-InvalidExtension requirement (correct test name) - Fix OTS verification heading depths (# -> ##) across all 10 docs - Create docs/verification/ots.md parent overview - Remove embedded Requirements Coverage sections from OTS verification docs - Create 10 OTS integration design docs under docs/design/ots/ - Update .reviewmark.yaml OTS review-sets to include design docs - Update design/introduction.md Scope to include OTS items - Remove non-existent TestResults cross-references from system design - Add missing invalid log-path scenario to cli/context.md - Fix cli/cli.md inaccuracies (direct Program.Main call; SilentFlow args) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: lint-fix pass before PR - Add 'Postconditions' to cspell word list - Fix British spellings: unrecognised -> unrecognized - Wrap long YAML title to comply with yamllint line-length - Wrap long lines in reviewmark-usage.md for markdownlint Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: move subsystem/system docs to parent folders per standard Per design-documentation.md and verification-documentation.md, system and subsystem docs belong in the PARENT folder, not inside their own subfolder. Moved (reqstream): template-dot-net-tool/template-dot-net-tool.yaml -> template-dot-net-tool.yaml template-dot-net-tool/cli/cli.yaml -> template-dot-net-tool/cli.yaml template-dot-net-tool/self-test/self-test.yaml -> template-dot-net-tool/self-test.yaml template-dot-net-tool/utilities/utilities.yaml -> template-dot-net-tool/utilities.yaml Moved (design): template-dot-net-tool/template-dot-net-tool.md -> template-dot-net-tool.md template-dot-net-tool/cli/cli.md -> template-dot-net-tool/cli.md template-dot-net-tool/self-test/self-test.md -> template-dot-net-tool/self-test.md template-dot-net-tool/utilities/utilities.md -> template-dot-net-tool/utilities.md Moved (verification): template-dot-net-tool/template-dot-net-tool.md -> template-dot-net-tool.md template-dot-net-tool/cli/cli.md -> template-dot-net-tool/cli.md template-dot-net-tool/self-test/self-test.md -> template-dot-net-tool/self-test.md template-dot-net-tool/utilities/utilities.md -> template-dot-net-tool/utilities.md Also created docs/design/ots.md (required OTS overview per standard). Updated requirements.yaml and .reviewmark.yaml references throughout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: update reviewmark.md requirement coverage IDs after split Remove IndexScan and WorkingDirectoryOverride scenarios (operations not required by this project). Update remaining three scenarios to reference the split requirement IDs: - ReviewMark_Enforce -> Template-OTS-ReviewMark-Enforce - ReviewMark_Elaborate -> Template-OTS-ReviewMark-Elaborate - ReviewMark_Lint -> Template-OTS-ReviewMark-Lint Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix definition.yaml paths after file moves, convert markdown hyperlinks to verbal references - docs/design/definition.yaml: update input-files to moved system/subsystem doc locations; add ots.md and ots/*.md entries - docs/verification/definition.yaml: update input-files to moved system/subsystem doc locations; add ots.md - docs/design/ots.md: convert markdown hyperlinks to verbal references - docs/verification/ots.md: convert markdown hyperlinks to verbal references; remove ### References section (only allowed in introduction.md) - docs/design/template-dot-net-tool.md: .NET 8/9/10 wording fix (framework compatibility specifications) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Puppeteer download issue in build-docs workflow Skip Puppeteer's bundled Chromium download (PUPPETEER_SKIP_DOWNLOAD=true) and instead locate the system-installed Chrome on Windows runners, matching the fix applied in demaconsulting/ReviewMark#72. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix heading depth and markdown hyperlinks from PR review #4559027817 - docs/verification/ots.md: promote top heading from ## to # (collection root level); shift Scope and OTS Items sections from ### to ## - docs/verification/introduction.md: convert markdown hyperlink to verbal reference with plain URL - docs/design/introduction.md: convert markdown hyperlink to verbal reference with plain URL Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Malcolm Nixon <Malcolm.Nixon@hiarc.inc> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Related Issues
Closes #
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
pwsh ./build.ps1Code Quality
Quality Checks
Please run the following checks before submitting:
pwsh ./lint.ps1Testing
Documentation
Additional Notes