fix: formal review fixes — results file directory creation and requirements scope cleanup

docs/reqstream/review-mark/self-test/validation.yaml

@@ -32,3 +32,4 @@ sections:
         tests:
           - Validation_Run_WithTrxResultsFile_WritesFile
           - Validation_Run_WithXmlResultsFile_WritesFile
+          - Validation_Run_WithResultsFileInNewDirectory_CreatesDirectory

src/DemaConsulting.ReviewMark/SelfTest/Validation.cs

@@ -117,7 +117,7 @@
 
             // Run the program capturing output to a log file
             int exitCode;
             using (var testContext = Context.Create(["--silent", "--log", logFile, "--version"]))
             {
                 Program.Run(testContext);
                 exitCode = testContext.ExitCode;
@@ -182,7 +182,7 @@
 
             // Run the program to generate the plan file
             int exitCode;
             using (var testContext = Context.Create(["--silent", "--definition", definitionFile, "--plan", planFile]))
             {
                 Program.Run(testContext);
                 exitCode = testContext.ExitCode;
@@ -531,6 +531,12 @@
                 return;
             }
 
+            var directory = Path.GetDirectoryName(context.ResultsFile);
+            if (!string.IsNullOrEmpty(directory))
+            {
+                Directory.CreateDirectory(directory);
+            }
+
             File.WriteAllText(context.ResultsFile, content);
             context.WriteLine($"Results written to {context.ResultsFile}");
         }

test/DemaConsulting.ReviewMark.Tests/SelfTest/ValidationTests.cs

@@ -202,4 +202,35 @@ public void Validation_Run_WithXmlResultsFile_WritesFile()
             }
         }
     }
+
+    /// <summary>
+    ///     Test that Run creates the parent directory when --results specifies a path with a non-existent parent.
+    /// </summary>
+    [TestMethod]
+    public void Validation_Run_WithResultsFileInNewDirectory_CreatesDirectory()
+    {
+        // Arrange — use TestDirectory as the root; the 'output' subdirectory does not exist yet
+        using var tempDir = new TestDirectory();
+        var subDir = Path.Combine(tempDir.DirectoryPath, "output");
+        var resultsFile = Path.Combine(subDir, "results.trx");
+
+        var originalOut = Console.Out;
+        try
+        {
+            using var outWriter = new StringWriter();
+            Console.SetOut(outWriter);
+            using var context = Context.Create(["--validate", "--results", resultsFile]);
+
+            // Act
+            Validation.Run(context);
+
+            // Assert — directory and results file were created
+            Assert.IsTrue(Directory.Exists(subDir), "Parent directory was not created");
+            Assert.IsTrue(File.Exists(resultsFile), "TRX results file was not created in new directory");
+        }
+        finally
+        {
+            Console.SetOut(originalOut);
+        }
+    }
 }