Sync with TemplateDotNetTool template PRs (#58, #65, #66, #67, #70, #75)#30
Sync with TemplateDotNetTool template PRs (#58, #65, #66, #67, #70, #75)#30Malcolmnixon merged 7 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/4f05d485-5375-4cca-952d-ddacf934b681 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
|
@copilot please make sure the review-sets in .reviewmark.yaml are appropriate. Read https://raw.githubusercontent.com/demaconsulting/ContinuousCompliance/refs/heads/main/docs/file-reviews.md to understand good review-set patterns. |
…text Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/45abfc5f-35fa-4006-b4f7-b799bd49c895 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Updated the review-sets in commit Key changes made:
|
|
@copilot The requirements.yaml file needs to be split into separate files (one for each software item) as defined by https://raw.githubusercontent.com/demaconsulting/ContinuousCompliance/refs/heads/main/docs/requirements.md then the review-sets adjusted. |
…ream/ and update .reviewmark.yaml Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/05c02ae5-9340-45f7-bc6a-bccbaa4d5dc3 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Done in commit
|
There was a problem hiding this comment.
Pull request overview
Syncs this repository with upstream TemplateDotNetTool conventions by reorganizing compliance documentation, adopting ReviewMark self-review configuration, and aligning CI/CD workflows and agent guidance with the template.
Changes:
- Replaced the monolithic
requirements.yamlwith a thin root file thatincludesfocused requirement files underdocs/reqstream/. - Renamed/restructured compliance docs folders and added new Pandoc document structures (requirements doc/report, code quality, build notes, review plan/report).
- Updated CI workflows to use new doc paths and to generate ReviewMark plan/report output; refreshed agent guidance and spelling dictionary entries.
Reviewed changes
Copilot reviewed 32 out of 41 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.yaml | Converts to a root ReqStream entrypoint that includes focused requirement files. |
| docs/tracematrix/definition.yaml | Removes old trace matrix Pandoc definition (folder renamed/replaced). |
| docs/requirements_report/title.txt | Adds Pandoc metadata for the requirements trace matrix document. |
| docs/requirements_report/introduction.md | Adds trace matrix introduction content. |
| docs/requirements_report/definition.yaml | Adds Pandoc definition for the trace matrix document. |
| docs/requirements_doc/title.txt | Adds Pandoc metadata for the requirements document. |
| docs/requirements_doc/introduction.md | Adds requirements document introduction content. |
| docs/requirements_doc/definition.yaml | Adds Pandoc definition for requirements + justifications doc compilation. |
| docs/requirements/definition.yaml | Removes old requirements Pandoc definition (folder renamed/replaced). |
| docs/reqstream/platform-requirements.yaml | Adds platform/runtime requirements in a focused file. |
| docs/reqstream/ots-requirements.yaml | Adds OTS requirements in a focused file. |
| docs/reqstream/index-requirements.yaml | Adds Index unit requirements in a focused file. |
| docs/reqstream/configuration-requirements.yaml | Adds configuration unit requirements in a focused file. |
| docs/reqstream/cli-requirements.yaml | Adds CLI subsystem requirements in a focused file. |
| docs/quality/definition.yaml | Removes old quality Pandoc definition (folder renamed/replaced). |
| docs/justifications/title.txt | Removes old justifications title (folded into requirements_doc output). |
| docs/justifications/introduction.md | Removes old justifications intro (folded into requirements_doc output). |
| docs/justifications/definition.yaml | Removes old justifications Pandoc definition (folder renamed/replaced). |
| docs/code_review_report/title.txt | Adds Pandoc metadata for ReviewMark review report. |
| docs/code_review_report/introduction.md | Adds review report introduction content. |
| docs/code_review_report/definition.yaml | Adds Pandoc definition for review report document. |
| docs/code_review_plan/title.txt | Adds Pandoc metadata for ReviewMark review plan. |
| docs/code_review_plan/introduction.md | Adds review plan introduction content. |
| docs/code_review_plan/definition.yaml | Adds Pandoc definition for review plan document. |
| docs/code_quality/title.txt | Adds Pandoc metadata for code quality document. |
| docs/code_quality/introduction.md | Adds code quality document introduction content. |
| docs/code_quality/definition.yaml | Adds Pandoc definition for code quality document. |
| docs/buildnotes/definition.yaml | Removes old buildnotes Pandoc definition (folder renamed/replaced). |
| docs/build_notes/title.txt | Adds Pandoc metadata for build notes document. |
| docs/build_notes/introduction.md | Adds build notes introduction content. |
| docs/build_notes/definition.yaml | Adds Pandoc definition for build notes document structure. |
| AGENTS.md | Updates agent naming/invocation format and expands quality gate guidance. |
| .reviewmark.yaml | Introduces ReviewMark self-review configuration (needs-review + review-sets + evidence source). |
| .gitignore | Updates generated-doc ignore paths to match renamed doc folders. |
| .github/workflows/release.yaml | Updates release body file reference to new build notes name/path. |
| .github/workflows/build.yaml | Updates doc generation paths and adds ReviewMark plan/report generation + conversion steps. |
| .github/agents/test-developer.agent.md | Replaces test developer agent guidance with template version. |
| .github/agents/technical-writer.agent.md | Replaces technical writer agent guidance with template version. |
| .github/agents/software-developer.agent.md | Replaces software developer agent guidance with template version. |
| .github/agents/requirements.agent.md | Replaces requirements agent guidance with template version. |
| .cspell.yaml | Updates allowed terms for renamed folders and new generated-doc names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot In the build-docs job of build.yaml the "Generate Review Plan and Review Report with ReviewMark" step should run the reviewmark global tool installed previously in the "Install ReviewMark from package" by just running "reviewmark". |
…d of dotnet run Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/5a482424-635c-4f04-afff-9a32e7b57c52 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Fixed in commit |
Pull Request
Description
Applies accumulated template repo changes from
demaconsulting/TemplateDotNetTool. Covers doc folder renames, ReviewMark self-review integration, updated agent files, and CI/CD workflow alignment.Documentation Structure
buildnotes/→build_notes/,quality/→code_quality/,requirements/→requirements_doc/,tracematrix/→requirements_report/justifications/folder (content folded intorequirements_doc/)code_review_plan/andcode_review_report/docs folders with definition filesReviewMark Self-Review Integration (PR #58)
.reviewmark.yamlfollowing the file-reviews.md guidance:needs-reviewtracksdocs/reqstream/*.yaml(the per-software-item requirements files)docs/guide/guide.mdincluded in theReviewMark-Programreview-setrequirements.yamlinto focused per-software-item files underdocs/reqstream/following requirements.md guidance:docs/reqstream/cli-requirements.yaml— allReviewMark-Cmd-*requirements (CLI subsystem)docs/reqstream/configuration-requirements.yaml—ReviewMark-Config-Reading(ReviewMarkConfiguration unit)docs/reqstream/index-requirements.yaml— evidence source and PDF parsing requirements (Index unit)docs/reqstream/platform-requirements.yaml— cross-platform support requirementsdocs/reqstream/ots-requirements.yaml— OTS software requirementsrequirements.yamlis now a thin root file usingincludesthat lists the five sub-filesCI/CD Workflows (PRs #65, #75)
build.yaml: doc path references, ReviewMark plan/report generation steps, artifact handlingbuild-docsjob to invokereviewmark(the globally installed tool) instead ofdotnet run --project src/DemaConsulting.ReviewMark ...release.yaml: usesartifacts/build_notes.mddirectly (removes the "Move buildnotes.md to root" step)Agent Files (PRs #66, #67, #70)
requirements,software-developer,technical-writer, andtest-developeragent files with comprehensive template versionsAGENTS.mdwith expanded quality gate enforcement and@agentinvocation formatSupporting Files
.gitignore: updated generated-doc exclusion paths.cspell.yaml: replaced old folder-name terms with new canonical namesType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReviewMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
Changes applied by the
repo-consistencyagent based on the 20 most recent merged PRs indemaconsulting/TemplateDotNetTool. No source code or test logic was modified; all changes are tooling, CI/CD, docs structure, and agent configuration.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.