Rename self-validation tests for clarity#18
Merged
Malcolmnixon merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update self-validation names for ReviewMark functionality
Rename self-validation tests for clarity
Mar 11, 2026
Malcolmnixon
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the clarity of ReviewMark’s self-validation output by renaming three self-validation test IDs to more explicitly describe the functionality they validate, and then updating all downstream references in requirements and documentation.
Changes:
- Renamed three self-validation test IDs in
Validation.csto follow theReviewMark_<Functionality>convention. - Updated
requirements.yamlreferences (including platform/runtime-filtered variants) to match the new IDs. - Updated sample validation output and test description lists in
README.mdanddocs/guide/guide.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DemaConsulting.ReviewMark/Validation.cs | Renames the three self-validation test ID strings used when reporting validation results. |
| requirements.yaml | Updates requirement-to-test mappings and platform/runtime-qualified test references to the new IDs. |
| docs/guide/guide.md | Updates documentation sample output and test descriptions to the new validation test IDs. |
| README.md | Updates README sample output and test descriptions to the new validation test IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-validation test names
ReviewMark_DefinitionPlan,ReviewMark_DefinitionReport, andReviewMark_Dirdon't clearly communicate what functionality they prove. Rename them to follow theReviewMark_Functionalityconvention with names that are self-explanatory.Changes
Validation.cs— update the three test ID strings passed toRunValidationTest:ReviewMark_DefinitionPlan→ReviewMark_ReviewPlanGenerationReviewMark_DefinitionReport→ReviewMark_ReviewReportGenerationReviewMark_Dir→ReviewMark_WorkingDirectoryOverriderequirements.yaml— update all 24 references (bare names +windows@,ubuntu@,macos@,dotnet8.x@,dotnet9.x@,dotnet10.x@filtered variants)README.mdanddocs/guide/guide.md— update sample output blocks and test description listsType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReviewMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
Self-validation output after the rename:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.