Skip to content

[WIP] Fix findings from code review of review-sets in .reviewmark.yaml#136

Merged
Malcolmnixon merged 3 commits intomainfrom
copilot/review-review-sets-fixes
Mar 28, 2026
Merged

[WIP] Fix findings from code review of review-sets in .reviewmark.yaml#136
Malcolmnixon merged 3 commits intomainfrom
copilot/review-review-sets-fixes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 27, 2026

  • Run code-review agent on ReqStream-System review-set using formal review template
  • Run code-review agent on ReqStream-Context review-set using formal review template
  • Run code-review agent on ReqStream-Program review-set using formal review template
  • Run code-review agent on ReqStream-Validation review-set using formal review template
  • Run code-review agent on ReqStream-Requirements review-set using formal review template
  • Run code-review agent on ReqStream-TraceMatrix review-set using formal review template
  • Run code-review agent on ReqStream-Linter review-set using formal review template
  • Run code-review agent on ReqStream-AllRequirements review-set using formal review template
  • Analyze all review reports for findings
  • Fix TEST-02 finding from System review: add ReqStream_EnforcementMode_FailsWhenRequirementLacksTestEvidence integration test to verify non-zero exit code on enforcement failure

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot Let's try this again. I want you to use the code-review agent to perform formal reviews of all review-sets in the .reviewmark.yaml file. Run all the code-review agents as unique sub-agents and instruct them to provide the populated review reports from the template markdown in the Continuous Compliance repository.

Once those sub-agents finish I want you to analyze their review reports and fix any issues reported in them.

…ailsWhenRequirementLacksTestEvidence)

Agent-Logs-Url: https://github.com/demaconsulting/ReqStream/sessions/10fcd60e-3e2d-4d64-9f8e-5033522501f9

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 28, 2026 01:49
Copilot AI review requested due to automatic review settings March 28, 2026 01:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an integration test and updates the System requirements mapping to ensure ReqStream enforcement mode is validated for the failure case (non-zero exit code when requirements lack passing test evidence), supporting CI/CD gating for unsatisfied requirements.

Changes:

  • Added ReqStream_EnforcementMode_FailsWhenRequirementLacksTestEvidence integration test to validate enforcement failure behavior.
  • Updated docs/reqstream/reqstream-system.yaml to link the System enforcement requirement to the new integration test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test/DemaConsulting.ReqStream.Tests/IntegrationTests.cs Adds a new end-to-end enforcement failure integration test using a temp requirements file and TRX input.
docs/reqstream/reqstream-system.yaml Registers the new test as evidence for the System enforcement-mode requirement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants