Sync recent TemplateDotNetTool updates into ReqStream#124
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
|
@copilot Please also incorporate demaconsulting/TemplateDotNetTool#55 |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Done in e3f6d64. PR #55 adds |
There was a problem hiding this comment.
Pull request overview
This PR syncs improvements from the demaconsulting/TemplateDotNetTool template into the ReqStream repository, adding macOS platform support across CI/CD, fixing the SonarScanner invocation, improving packaging, and making CodeQL build mode explicit.
Changes:
- Add macOS to build and integration test OS matrices, add
ReqStream-Plt-MacOSplatform requirement, and updateAGENTS.mdto document the new platform - Fix Sonar Scanner CLI invocation (
dotnet dotnet-sonarscanner), addGITHUB_TOKENenv to both Sonar steps, and make thefetch-depth: 0consistent in the build job - Add a new question/help GitHub issue template and explanatory comments to the test project's
.csproj
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/ISSUE_TEMPLATE/question.yml |
New GitHub issue template for user questions and help requests |
AGENTS.md |
Adds Agent Selection Guide, macos@ test source filter, and updated CI/CD platform list |
requirements.yaml |
Adds ReqStream-Plt-MacOS requirement with macos@ prefixed test evidence |
.github/workflows/build.yaml |
Adds macOS to OS matrices, fixes Sonar Scanner, pack, CodeQL build-mode, and mermaid filter |
test/DemaConsulting.ReqStream.Tests/DemaConsulting.ReqStream.Tests.csproj |
Moves GenerateDocumentationFile outside the code quality comment block; adds explanatory comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pull Request
Description
Pulls in improvements from
demaconsulting/TemplateDotNetToolPRs #48, #52, #54, and #55. Key themes: macOS platform support, Sonar Scanner invocation fix, packaging/CodeQL correctness, and explicit CodeQL build mode..github/ISSUE_TEMPLATE/question.yml(new)AGENTS.mdmacos@TestNamesource filter to Test Source Filters listrequirements.yamlmacos@TestNameto header commentReqStream-Plt-MacOSplatform requirement withmacos@filtered test evidence.github/workflows/build.yamlmacos-latestto build and integration test OS matricess/-latest//(covers all three platforms)fetch-depth: 0to build job checkoutdotnet dotnet-sonarscanner+GITHUB_TOKENenv on begin/end steps--no-restore+PackageVersionproperty (drop--configuration Release)build-mode: manualto CodeQL init step to make existing intent explicit (template PR [Feature]: Implement Self Validation #55)--filter node_modules/.bin/mermaid-filter.cmdto Code Quality, Requirements, Justifications, and Trace Matrix pandoc stepsshell: bashfrom SarifMark steptest/DemaConsulting.ReqStream.Tests.csprojGenerateDocumentationFileoutside the Code Quality Configuration comment blockcoverlet.collectorand analyzerPackageReferencechild-element formType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
macOS CI runs will supply
macos@prefixed test results to satisfyReqStream-Plt-MacOS. Until the first macOS CI run completes, that requirement will show as unsatisfied under--enforcewith local results only — consistent with the existing behavior for the Windows and Linux platform requirements.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.