Skip to content

Sync recent TemplateDotNetTool updates into ReqStream#124

Merged
Malcolmnixon merged 5 commits intomainfrom
copilot/update-template-with-recent-changes
Mar 6, 2026
Merged

Sync recent TemplateDotNetTool updates into ReqStream#124
Malcolmnixon merged 5 commits intomainfrom
copilot/update-template-with-recent-changes

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

Pull Request

Description

Pulls in improvements from demaconsulting/TemplateDotNetTool PRs #48, #52, #54, and #55. Key themes: macOS platform support, Sonar Scanner invocation fix, packaging/CodeQL correctness, and explicit CodeQL build mode.

.github/ISSUE_TEMPLATE/question.yml (new)

  • Add question/help issue template

AGENTS.md

  • Add "Agent Selection Guide" section mapping task types to agents
  • Add macos@TestName source filter to Test Source Filters list
  • Update CI/CD bullets to reflect Windows/Linux/macOS support

requirements.yaml

  • Add macos@TestName to header comment
  • Add ReqStream-Plt-MacOS platform requirement with macos@ filtered test evidence

.github/workflows/build.yaml

  • Add macos-latest to build and integration test OS matrices
  • Simplify OS_SHORT sed: s/-latest// (covers all three platforms)
  • Add fetch-depth: 0 to build job checkout
  • Fix Sonar Scanner: dotnet dotnet-sonarscanner + GITHUB_TOKEN env on begin/end steps
  • Fix pack: --no-restore + PackageVersion property (drop --configuration Release)
  • Add build-mode: manual to CodeQL init step to make existing intent explicit (template PR [Feature]: Implement Self Validation #55)
  • Add --filter node_modules/.bin/mermaid-filter.cmd to Code Quality, Requirements, Justifications, and Trace Matrix pandoc steps
  • Remove spurious shell: bash from SarifMark step

test/DemaConsulting.ReqStream.Tests.csproj

  • Move GenerateDocumentationFile outside the Code Quality Configuration comment block
  • Add explanatory comments for coverlet.collector and analyzer PackageReference child-element form

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

macOS CI runs will supply macos@ prefixed test results to satisfy ReqStream-Plt-MacOS. Until the first macOS CI run completes, that requirement will show as unsatisfied under --enforce with local results only — consistent with the existing behavior for the Windows and Linux platform requirements.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update template with recent changes Sync recent TemplateDotNetTool updates into ReqStream Mar 6, 2026
@Malcolmnixon
Copy link
Contributor

@copilot Please also incorporate demaconsulting/TemplateDotNetTool#55

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 6, 2026

@copilot Please also incorporate demaconsulting/TemplateDotNetTool#55

Done in e3f6d64. PR #55 adds build-mode: manual back to the CodeQL init step (making the existing intent explicit), which I had removed as part of the previous sync. The property is now restored with build-mode: manual placed before queries to match the template's formatting.

@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 6, 2026 16:56
Copilot AI review requested due to automatic review settings March 6, 2026 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs improvements from the demaconsulting/TemplateDotNetTool template into the ReqStream repository, adding macOS platform support across CI/CD, fixing the SonarScanner invocation, improving packaging, and making CodeQL build mode explicit.

Changes:

  • Add macOS to build and integration test OS matrices, add ReqStream-Plt-MacOS platform requirement, and update AGENTS.md to document the new platform
  • Fix Sonar Scanner CLI invocation (dotnet dotnet-sonarscanner), add GITHUB_TOKEN env to both Sonar steps, and make the fetch-depth: 0 consistent in the build job
  • Add a new question/help GitHub issue template and explanatory comments to the test project's .csproj

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/ISSUE_TEMPLATE/question.yml New GitHub issue template for user questions and help requests
AGENTS.md Adds Agent Selection Guide, macos@ test source filter, and updated CI/CD platform list
requirements.yaml Adds ReqStream-Plt-MacOS requirement with macos@ prefixed test evidence
.github/workflows/build.yaml Adds macOS to OS matrices, fixes Sonar Scanner, pack, CodeQL build-mode, and mermaid filter
test/DemaConsulting.ReqStream.Tests/DemaConsulting.ReqStream.Tests.csproj Moves GenerateDocumentationFile outside the code quality comment block; adds explanatory comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Malcolmnixon and others added 2 commits March 6, 2026 12:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants