Skip to content

Fix MSTest analyzer warnings (MSTEST0058, MSTEST0037) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 4 commits into from
Feb 13, 2026
Merged

Fix MSTest analyzer warnings (MSTEST0058, MSTEST0037) #107

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b6eb98
Initial plan
Copilot Feb 13, 2026
8664451
Fix Sonar code quality issues in test files
Copilot Feb 13, 2026
976a7e1
Fix Sonar issues with clear assertions
Copilot Feb 13, 2026
cce429b
Use Assert.ContainsSingle for cleaner assertions
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/DemaConsulting.ReqStream.Tests/ContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,8 @@ public void Context_Create_WithRequirementsPattern_ExpandsGlobPattern()
using var context = Context.Create(["--requirements", "*.yaml"]);

Assert.HasCount(2, context.RequirementsFiles);
Assert.IsTrue(context.RequirementsFiles.Any(f => f.EndsWith("req1.yaml")));
Assert.IsTrue(context.RequirementsFiles.Any(f => f.EndsWith("req2.yaml")));
Assert.AreEqual(1, context.RequirementsFiles.Count(f => f.EndsWith("req1.yaml")));
Assert.AreEqual(1, context.RequirementsFiles.Count(f => f.EndsWith("req2.yaml")));
Assert.AreEqual(0, context.ExitCode);
}
finally
Expand Down Expand Up @@ -500,8 +500,8 @@ public void Context_Create_WithTestsPattern_ExpandsGlobPattern()
using var context = Context.Create(["--tests", "*.trx"]);

Assert.HasCount(2, context.TestFiles);
Assert.IsTrue(context.TestFiles.Any(f => f.EndsWith("test1.trx")));
Assert.IsTrue(context.TestFiles.Any(f => f.EndsWith("test2.trx")));
Assert.AreEqual(1, context.TestFiles.Count(f => f.EndsWith("test1.trx")));
Assert.AreEqual(1, context.TestFiles.Count(f => f.EndsWith("test2.trx")));
Assert.AreEqual(0, context.ExitCode);
}
finally
Expand Down
15 changes: 4 additions & 11 deletions test/DemaConsulting.ReqStream.Tests/RequirementsReadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,17 +786,10 @@ public void Requirements_Read_MultipleFilesWithDuplicateIds_ThrowsException()
File.WriteAllText(file1Path, file1Yaml);
File.WriteAllText(file2Path, file2Yaml);

try
{
Requirements.Read(file1Path, file2Path);
Assert.Fail("Expected InvalidOperationException was not thrown");
}
catch (InvalidOperationException ex)
{
Assert.Contains("SYS-SEC-001", ex.Message);
Assert.Contains("Duplicate requirement ID", ex.Message);
Assert.Contains(file2Path, ex.Message);
}
var ex = Assert.ThrowsExactly<InvalidOperationException>(() => Requirements.Read(file1Path, file2Path));
Assert.Contains("SYS-SEC-001", ex.Message);
Assert.Contains("Duplicate requirement ID", ex.Message);
Assert.Contains(file2Path, ex.Message);
}

/// <summary>
Expand Down
Loading