Pack all library packages into a flat release artifact#4
Merged
Conversation
The release produced only one NuGet package because the 'Upload packages' step collected packages from a single project's bin/Release folder (src/DemaConsulting.Rendering/), while 'dotnet pack' writes each of the five library packages into its own per-project bin/Release folder. The other four nupkg/snupkg were never uploaded, so the release job never saw them. Pack the solution into a single flat 'packages' output directory (dotnet pack --output packages) so all five nupkg and their snupkg symbol packages land in one folder, and upload packages/*.nupkg and packages/*.snupkg. The resulting packages-<os> artifact is a flat archive with every package file at its root, which the release job extracts to artifacts/ for 'dotnet nuget push artifacts/*.nupkg' and the GitHub release. Verified locally: 'dotnet pack Rendering.slnx --output packages' emits all five library nupkg plus five snupkg into one flat folder, with no test packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the build workflow packaging output so the release pipeline receives all NuGet packages (and symbols) produced by solution-wide packing, rather than only those emitted under a single project’s bin/Release directory.
Changes:
- Packs with
dotnet pack --output packagesto emit all.nupkg/.snupkginto a single flat output folder. - Uploads
packages/*.nupkgandpackages/*.snupkgas thepackages-<os>artifact so the release job can pushartifacts/*.nupkg.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release produced only one NuGet package because the 'Upload packages' step collected packages from a single project's bin/Release folder (src/DemaConsulting.Rendering/), while 'dotnet pack' writes each of the five library packages into its own per-project bin/Release folder. The other four nupkg/snupkg were never uploaded, so the release job never saw them.
Pack the solution into a single flat 'packages' output directory (dotnet pack --output packages) so all five nupkg and their snupkg symbol packages land in one folder, and upload packages/.nupkg and packages/.snupkg. The resulting packages- artifact is a flat archive with every package file at its root, which the release job extracts to artifacts/ for 'dotnet nuget push artifacts/*.nupkg' and the GitHub release.
Verified locally: 'dotnet pack Rendering.slnx --output packages' emits all five library nupkg plus five snupkg into one flat folder, with no test packages.