Skip to content

Fix design documentation issues found in formal review #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 3 commits into from
Apr 5, 2026
Merged

Fix design documentation issues found in formal review #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
183a12c
Fix design doc issues found in formal review
Copilot Apr 5, 2026
88a88d3
Revert test folder layout addition from design doc
Copilot Apr 5, 2026
32525c4
Remove test folder layout section from design doc
Copilot Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/design/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Test code mirrors the source structure:

```text
Comment thread
Malcolmnixon marked this conversation as resolved.
Outdated
test/DemaConsulting.NuGet.Caching.Tests/
├── NuGetCachingTests.cs — System-level integration tests
├── NuGetCacheTests.cs — Tests for NuGetCache class
└── PathHelpersTests.cs — Tests for PathHelpers class
```
Expand Down
2 changes: 1 addition & 1 deletion docs/design/nuget-caching/nuget-cache.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ cache. The method:

Returns the absolute path to the cached package folder.

Satisfies requirements `Caching-Lib-EnsureCached` and `Caching-Lib-NullValidation`.
Satisfies requirements `Caching-Lib-EnsureCached`, `Caching-Lib-NullValidation`, and `Caching-Lib-NotFound`.

### `TryDownloadPackageAsync` (private)

Expand Down