Align repository structure with updated DEMA Consulting standards#23
Conversation
…tandards - Delete docs/design/introduction.txt and create docs/design/introduction.md with required Software Structure and Folder Layout sections - Create docs/design/system.md with system architecture, external interfaces, data flow, and design constraints - Rename docs/design/nuget-cache-design.md -> docs/design/nuget-cache.md - Rename docs/design/path-helpers-design.md -> docs/design/path-helpers.md - Create docs/reqstream/system.yaml with system-level requirements - Rename docs/reqstream/unit-nuget-cache.yaml -> docs/reqstream/nuget-cache.yaml - Rename docs/reqstream/unit-path-helpers.yaml -> docs/reqstream/path-helpers.yaml - Move all OTS reqstream files into docs/reqstream/ots/ subdirectory - Update requirements.yaml includes to use new file paths - Update .reviewmark.yaml with standard review-sets including system-level reviews and requirements.yaml in needs-review Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/demaconsulting/NuGetCaching/sessions/e5e94eae-08de-42b6-ba75-f5ccf093f18a Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository’s design and requirements documentation (and associated review tracking) to align with updated DEMA Consulting standards for design docs, requirements traceability, and ReviewMark review-set organization.
Changes:
- Reorganized requirements under
docs/reqstream/(added system-level requirements, renamed unit requirement files, and moved OTS requirements intodocs/reqstream/ots/). - Reorganized design documentation under
docs/design/(migrated introduction to Markdown, added system design, and renamed unit design docs to drop-designsuffix). - Updated root
requirements.yamlinclude paths and streamlined.reviewmark.yamlreview-set definitions (including globbing for design docs).
Reviewed changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.yaml | Updates ReqStream include paths to match the new requirements file layout. |
| docs/reqstream/system.yaml | Adds system-level requirements for the library. |
| docs/reqstream/nuget-cache.yaml | Adds/relocates NuGetCache unit requirements under the new naming scheme. |
| docs/reqstream/path-helpers.yaml | Adds/relocates PathHelpers unit requirements under the new naming scheme. |
| docs/reqstream/ots/buildmark.yaml | Relocates BuildMark OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/mstest.yaml | Relocates MSTest OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/nuget.yaml | Relocates NuGet client SDK OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/reqstream.yaml | Relocates ReqStream OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/reviewmark.yaml | Relocates ReviewMark OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/sarifmark.yaml | Relocates SarifMark OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/sonarmark.yaml | Relocates SonarMark OTS requirements into ots/ subfolder. |
| docs/reqstream/ots/versionmark.yaml | Relocates VersionMark OTS requirements into ots/ subfolder. |
| docs/design/introduction.txt | Removes the old text-based design introduction. |
| docs/design/introduction.md | Adds Markdown introduction with required “Software Structure” and “Folder Layout” sections. |
| docs/design/system.md | Adds system-level design documentation (architecture, interfaces, data flow). |
| docs/design/nuget-cache.md | Renames/updates NuGetCache unit design doc to the new standard filename. |
| docs/design/path-helpers.md | Renames/updates PathHelpers unit design doc to the new standard filename. |
| .reviewmark.yaml | Updates review scope patterns and review-sets to match the new file layout and standard grouping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot Documentation build failed with |
Agent-Logs-Url: https://github.com/demaconsulting/NuGetCaching/sessions/db60e134-7b2f-4528-888d-4f960e9b3f11 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Fixed in 17e932d — updated Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Pull Request
Description
Restructures docs/design, docs/reqstream, and .reviewmark.yaml to comply with updated DEMA Consulting standards for design documentation, requirements traceability, and file review tracking.
docs/design/introduction.txtwithintroduction.mdcontaining required Software Structure and Folder Layout sectionssystem.mdwith system architecture, interfaces, and data flow (OTS dependency descriptions reference package names only, without version numbers)nuget-cache-design.md→nuget-cache.mdandpath-helpers-design.md→path-helpers.md(removed-designsuffix per standard)definition.yaml(Pandoc defaults) to reference the renamed files and includesystem.mdso documentation builds correctlydocs/reqstream/system.yamlfor system-level requirementsunit-nuget-cache.yaml→nuget-cache.yamlandunit-path-helpers.yaml→path-helpers.yaml(removedunit-prefix per standard)ots-*.yamlfiles intoots/subfolderrequirements.yaml.reviewmark.yamlrequirements.yamltoneeds-reviewsetdocs/design/**/*.mdinNuGetCaching-Designreview set instead of explicit file listingNuGetCaching-OTSandNuGetCaching-Platformreview sets (both are fully covered byNuGetCaching-AllRequirements)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
Pure structural/naming alignment — no logic or behavior changes. All linters pass post-restructure.