Skip to content

Align repository structure with updated DEMA Consulting standards#23

Merged
Malcolmnixon merged 3 commits intomainfrom
copilot/update-repository-to-comply-standards
Apr 2, 2026
Merged

Align repository structure with updated DEMA Consulting standards#23
Malcolmnixon merged 3 commits intomainfrom
copilot/update-repository-to-comply-standards

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

Pull Request

Description

Restructures docs/design, docs/reqstream, and .reviewmark.yaml to comply with updated DEMA Consulting standards for design documentation, requirements traceability, and file review tracking.

docs/design/

  • Replaced introduction.txt with introduction.md containing required Software Structure and Folder Layout sections
  • Added system.md with system architecture, interfaces, and data flow (OTS dependency descriptions reference package names only, without version numbers)
  • Renamed nuget-cache-design.mdnuget-cache.md and path-helpers-design.mdpath-helpers.md (removed -design suffix per standard)
  • Updated definition.yaml (Pandoc defaults) to reference the renamed files and include system.md so documentation builds correctly

docs/reqstream/

  • Added system.yaml for system-level requirements
  • Renamed unit-nuget-cache.yamlnuget-cache.yaml and unit-path-helpers.yamlpath-helpers.yaml (removed unit- prefix per standard)
  • Moved all ots-*.yaml files into ots/ subfolder

requirements.yaml

  • Updated all include paths to match new file locations

.reviewmark.yaml

  • Added requirements.yaml to needs-review set
  • Used glob pattern docs/design/**/*.md in NuGetCaching-Design review set instead of explicit file listing
  • Removed standalone NuGetCaching-OTS and NuGetCaching-Platform review sets (both are fully covered by NuGetCaching-AllRequirements)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Pure structural/naming alignment — no logic or behavior changes. All linters pass post-restructure.

…tandards

- Delete docs/design/introduction.txt and create docs/design/introduction.md
  with required Software Structure and Folder Layout sections
- Create docs/design/system.md with system architecture, external interfaces,
  data flow, and design constraints
- Rename docs/design/nuget-cache-design.md -> docs/design/nuget-cache.md
- Rename docs/design/path-helpers-design.md -> docs/design/path-helpers.md
- Create docs/reqstream/system.yaml with system-level requirements
- Rename docs/reqstream/unit-nuget-cache.yaml -> docs/reqstream/nuget-cache.yaml
- Rename docs/reqstream/unit-path-helpers.yaml -> docs/reqstream/path-helpers.yaml
- Move all OTS reqstream files into docs/reqstream/ots/ subdirectory
- Update requirements.yaml includes to use new file paths
- Update .reviewmark.yaml with standard review-sets including system-level
  reviews and requirements.yaml in needs-review

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 2, 2026 14:53
Copilot AI review requested due to automatic review settings April 2, 2026 14:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the repository’s design and requirements documentation (and associated review tracking) to align with updated DEMA Consulting standards for design docs, requirements traceability, and ReviewMark review-set organization.

Changes:

  • Reorganized requirements under docs/reqstream/ (added system-level requirements, renamed unit requirement files, and moved OTS requirements into docs/reqstream/ots/).
  • Reorganized design documentation under docs/design/ (migrated introduction to Markdown, added system design, and renamed unit design docs to drop -design suffix).
  • Updated root requirements.yaml include paths and streamlined .reviewmark.yaml review-set definitions (including globbing for design docs).

Reviewed changes

Copilot reviewed 6 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
requirements.yaml Updates ReqStream include paths to match the new requirements file layout.
docs/reqstream/system.yaml Adds system-level requirements for the library.
docs/reqstream/nuget-cache.yaml Adds/relocates NuGetCache unit requirements under the new naming scheme.
docs/reqstream/path-helpers.yaml Adds/relocates PathHelpers unit requirements under the new naming scheme.
docs/reqstream/ots/buildmark.yaml Relocates BuildMark OTS requirements into ots/ subfolder.
docs/reqstream/ots/mstest.yaml Relocates MSTest OTS requirements into ots/ subfolder.
docs/reqstream/ots/nuget.yaml Relocates NuGet client SDK OTS requirements into ots/ subfolder.
docs/reqstream/ots/reqstream.yaml Relocates ReqStream OTS requirements into ots/ subfolder.
docs/reqstream/ots/reviewmark.yaml Relocates ReviewMark OTS requirements into ots/ subfolder.
docs/reqstream/ots/sarifmark.yaml Relocates SarifMark OTS requirements into ots/ subfolder.
docs/reqstream/ots/sonarmark.yaml Relocates SonarMark OTS requirements into ots/ subfolder.
docs/reqstream/ots/versionmark.yaml Relocates VersionMark OTS requirements into ots/ subfolder.
docs/design/introduction.txt Removes the old text-based design introduction.
docs/design/introduction.md Adds Markdown introduction with required “Software Structure” and “Folder Layout” sections.
docs/design/system.md Adds system-level design documentation (architecture, interfaces, data flow).
docs/design/nuget-cache.md Renames/updates NuGetCache unit design doc to the new standard filename.
docs/design/path-helpers.md Renames/updates PathHelpers unit design doc to the new standard filename.
.reviewmark.yaml Updates review scope patterns and review-sets to match the new file layout and standard grouping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot Documentation build failed with pandoc.exe: docs/design/introduction.txt: withBinaryFile: does not exist (No such file or directory) please fix.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

@copilot Documentation build failed with pandoc.exe: docs/design/introduction.txt: withBinaryFile: does not exist (No such file or directory) please fix.

Fixed in 17e932d — updated docs/design/definition.yaml to reference the renamed files (introduction.md, system.md, nuget-cache.md, path-helpers.md).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from Malcolmnixon April 2, 2026 15:17
@Malcolmnixon Malcolmnixon merged commit 4ba3655 into main Apr 2, 2026
6 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/update-repository-to-comply-standards branch April 2, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants