Repository navigation
Pack NuGet output to a flat packages folder - #32
Merged
Merged
Conversation
dotnet pack previously wrote each project's .nupkg/.snupkg to its own src/<project>/bin/Release/, so the packages-* artifact preserved that nested layout. actions/upload-artifact roots its archive at the common ancestor of matched paths, so the downloaded artifact was not a usable flat local NuGet feed, and release.yaml's existing artifacts/*.nupkg push step would have found nothing. Pack with --output packages so all projects write directly into one flat folder, matching the pattern used by DocDown's build pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow change addresses the package layout issue with no unresolved review concerns.
Review effort: Lite
Findings: None
What changed in this PR
Updates the build workflow to produce a flat NuGet package artifact compatible with release publishing.
Changes:
- Packs all projects into
packages/. - Uploads the flat package directory as the artifact.
| File | Description |
|---|---|
.github/workflows/build.yaml |
Configures flat package output and artifact upload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The
packages-*build artifact was nested:dotnet packwrote each project's.nupkg/.snupkgto its ownsrc/<project>/bin/Release/, andactions/upload-artifactroots the archive at the common ancestor of thematched paths, so the downloaded artifact preserved that nested
src/<project>/bin/Release/structure instead of being a flat, directlyusable local NuGet feed. This also meant
release.yaml's existingdotnet nuget push artifacts/*.nupkgstep would find nothing.Changed the
Create Library Packagestep to pack with--output packagesso all three projects write their
.nupkg/.snupkgdirectly into one flatpackages/folder, and upload that folder as-is. This matches the patternalready used by DocDown's build pipeline.
Type of Change
Related Issues
Closes #
Pre-Submission Checklist
Build and Test
pwsh ./build.ps1(no sourcechanges in this PR; verified separately that
dotnet pack --output packagesproduces a flat
packages/folder with all 6 expected.nupkg/.snupkgfiles)Code Quality
Quality Checks
pwsh ./lint.ps1- passedTesting
Documentation
Additional Notes
Verified locally:
dotnet pack --configuration Release --output packages --property:PackageVersion=9.9.9-testproduced exactly:with no nested project subfolders.