Skip to content

Standardize GitHub GraphQL type naming for consistency #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 2 commits into from
Feb 17, 2026
Merged

Standardize GitHub GraphQL type naming for consistency #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdd39d
Initial plan
Copilot Feb 17, 2026
8e171a7
Rename IssueNode to LinkedIssueReference and IssueNodeData to IssueNo…
Copilot Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DemaConsulting.BuildMark/RepoConnectors/GitHub/GitHubGraphQLClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,13 +483,13 @@ public async Task<List<PullRequestNode>> GetPullRequestsAsync(
/// <param name="owner">Repository owner.</param>
/// <param name="repo">Repository name.</param>
/// <returns>List of issue nodes.</returns>
public async Task<List<IssueNodeData>> GetAllIssuesAsync(
public async Task<List<IssueNode>> GetAllIssuesAsync(
string owner,
string repo)
{
try
{
var allIssueNodes = new List<IssueNodeData>();
var allIssueNodes = new List<IssueNode>();
string? afterCursor = null;
bool hasNextPage;

Expand Down
12 changes: 6 additions & 6 deletions src/DemaConsulting.BuildMark/RepoConnectors/GitHub/GitHubGraphQLTypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ internal record PullRequestData(
/// <summary>
/// Closing issues references data containing nodes and page info.
/// </summary>
/// <param name="Nodes">Issue nodes.</param>
/// <param name="Nodes">Linked issue references.</param>
/// <param name="PageInfo">Pagination information.</param>
internal record ClosingIssuesReferencesData(
List<IssueNode>? Nodes,
List<LinkedIssueReference>? Nodes,
PageInfo? PageInfo);

/// <summary>
/// Issue node containing issue number.
/// Linked issue reference containing minimal issue information.
/// </summary>
/// <param name="Number">Issue number.</param>
internal record IssueNode(
internal record LinkedIssueReference(
int? Number);

/// <summary>
Expand Down Expand Up @@ -262,7 +262,7 @@ internal record IssueRepositoryData(
/// <param name="Nodes">Issue nodes.</param>
/// <param name="PageInfo">Pagination information.</param>
internal record IssuesConnectionData(
List<IssueNodeData>? Nodes,
List<IssueNode>? Nodes,
PageInfo? PageInfo);

/// <summary>
Expand All @@ -273,7 +273,7 @@ internal record IssuesConnectionData(
/// <param name="Url">Issue HTML URL.</param>
/// <param name="State">Issue state (OPEN or CLOSED).</param>
/// <param name="Labels">Labels assigned to the issue.</param>
internal record IssueNodeData(
internal record IssueNode(
int? Number,
string? Title,
string? Url,
Expand Down
2 changes: 1 addition & 1 deletion src/DemaConsulting.BuildMark/RepoConnectors/GitHubRepoConnector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ private static async Task<IReadOnlyList<IssueInfo>> GetAllIssuesAsync(
// Fetch all issues for the repository using GraphQL
var issueNodes = await graphqlClient.GetAllIssuesAsync(owner, repo);

// Convert IssueNodeData objects to IssueInfo objects
// Convert IssueNode objects to IssueInfo objects
return issueNodes
.Where(issue => issue.Number.HasValue && !string.IsNullOrEmpty(issue.Title))
.Select(issue => new IssueInfo(
Expand Down