Skip to content

Sync agent/standards files and lint scripts from TemplateDotNetTool; rename code-review agent to formal-review#136

Merged
Malcolmnixon merged 1 commit intomainfrom
copilot/copy-updated-files-from-template
Apr 9, 2026
Merged

Sync agent/standards files and lint scripts from TemplateDotNetTool; rename code-review agent to formal-review#136
Malcolmnixon merged 1 commit intomainfrom
copilot/copy-updated-files-from-template

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

Binary-copies updated files from demaconsulting/TemplateDotNetTool and renames the code-review agent to formal-review.

Agent Files (/.github/agents/)

  • Renamed code-review.agent.mdformal-review.agent.md (content unchanged, binary copy of template source)
  • Updated quality.agent.md — adds two Testing Compliance checklist items (hierarchy boundary and cross-hierarchy dependency checks); moves Result field explanation to after the report template block
  • Binary-copied developer.agent.md, implementation.agent.md, repo-consistency.agent.md

Standards Files (/.github/standards/)

  • New: coding-principles.md — universal literate coding and architecture principles
  • New: testing-principles.md — universal AAA pattern and test dependency boundary rules
  • Updated all existing standards files with YAML front matter and revised content (binary copies)

Supporting Files

  • AGENTS.md — binary copy from template; code-review references replaced with formal-review
  • lint.sh / lint.bat — expanded to include dotnet tool restore, reqstream --lint, versionmark --lint, reviewmark --lint, and dotnet restore before dotnet format

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.BuildMark --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

All .github/agents/*.md and .github/standards/*.md files verified as byte-for-byte identical to the template via git blob SHA comparison.

…e-review to formal-review)

Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/91d7f5a0-1173-4c51-869e-76c5c1a7bce1

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 9, 2026 23:12
Copilot AI review requested due to automatic review settings April 9, 2026 23:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this repository’s agent/standards documentation and linting workflow with demaconsulting/TemplateDotNetTool, including renaming the formal review agent from code-review to formal-review.

Changes:

  • Expands lint.sh / lint.bat to restore dotnet tools and run reqstream, versionmark, and reviewmark lint steps before formatting.
  • Adds new universal standards (coding-principles.md, testing-principles.md) and updates existing standards with YAML front matter and revised guidance.
  • Updates agent docs (including a new formal-review.agent.md) and refreshes AGENTS.md references accordingly.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lint.sh Adds Puppeteer skip flag; restores dotnet tools; runs reqstream/versionmark/reviewmark lint; restores packages before dotnet format --no-restore.
lint.bat Mirrors lint.sh changes for Windows with explicit section abort handling and added dotnet lint steps.
AGENTS.md Updates project placeholders and switches references from code-review to formal-review; adds new standards references.
.github/standards/coding-principles.md New universal coding principles and quality gates standard.
.github/standards/testing-principles.md New universal testing principles (AAA + hierarchy boundary rules) and quality gate checklist.
.github/standards/csharp-language.md Adds YAML front matter and refocuses C# language standard to depend on universal coding principles.
.github/standards/csharp-testing.md Adds YAML front matter; adds “Required Standards”; aligns with new testing principles.
.github/standards/design-documentation.md Adds YAML front matter; adds “Required Standards”; clarifies scope exclusions.
.github/standards/reqstream-usage.md Adds YAML front matter and required-standards section; clarifies hierarchy link guidance.
.github/standards/reviewmark-usage.md Adds YAML front matter and required-standards section.
.github/standards/software-items.md Adds YAML front matter and expands subsystem/unit definitions.
.github/standards/technical-documentation.md Adds YAML front matter and clarifies what belongs in “References” sections.
.github/agents/quality.agent.md Adds testing compliance checklist items; moves Result-field explanation to after the template block.
.github/agents/formal-review.agent.md Introduces renamed formal review agent file (currently still labeled code-review in front matter).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon merged commit 8d706c3 into main Apr 9, 2026
19 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/copy-updated-files-from-template branch April 9, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants