Sync agent/standards files and lint scripts from TemplateDotNetTool; rename code-review agent to formal-review#136
Merged
Malcolmnixon merged 1 commit intomainfrom Apr 9, 2026
Conversation
…e-review to formal-review) Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/91d7f5a0-1173-4c51-869e-76c5c1a7bce1 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 9, 2026 23:11
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs this repository’s agent/standards documentation and linting workflow with demaconsulting/TemplateDotNetTool, including renaming the formal review agent from code-review to formal-review.
Changes:
- Expands
lint.sh/lint.batto restore dotnet tools and runreqstream,versionmark, andreviewmarklint steps before formatting. - Adds new universal standards (
coding-principles.md,testing-principles.md) and updates existing standards with YAML front matter and revised guidance. - Updates agent docs (including a new
formal-review.agent.md) and refreshes AGENTS.md references accordingly.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lint.sh | Adds Puppeteer skip flag; restores dotnet tools; runs reqstream/versionmark/reviewmark lint; restores packages before dotnet format --no-restore. |
| lint.bat | Mirrors lint.sh changes for Windows with explicit section abort handling and added dotnet lint steps. |
| AGENTS.md | Updates project placeholders and switches references from code-review to formal-review; adds new standards references. |
| .github/standards/coding-principles.md | New universal coding principles and quality gates standard. |
| .github/standards/testing-principles.md | New universal testing principles (AAA + hierarchy boundary rules) and quality gate checklist. |
| .github/standards/csharp-language.md | Adds YAML front matter and refocuses C# language standard to depend on universal coding principles. |
| .github/standards/csharp-testing.md | Adds YAML front matter; adds “Required Standards”; aligns with new testing principles. |
| .github/standards/design-documentation.md | Adds YAML front matter; adds “Required Standards”; clarifies scope exclusions. |
| .github/standards/reqstream-usage.md | Adds YAML front matter and required-standards section; clarifies hierarchy link guidance. |
| .github/standards/reviewmark-usage.md | Adds YAML front matter and required-standards section. |
| .github/standards/software-items.md | Adds YAML front matter and expands subsystem/unit definitions. |
| .github/standards/technical-documentation.md | Adds YAML front matter and clarifies what belongs in “References” sections. |
| .github/agents/quality.agent.md | Adds testing compliance checklist items; moves Result-field explanation to after the template block. |
| .github/agents/formal-review.agent.md | Introduces renamed formal review agent file (currently still labeled code-review in front matter). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary-copies updated files from
demaconsulting/TemplateDotNetTooland renames the code-review agent toformal-review.Agent Files (
/.github/agents/)code-review.agent.md→formal-review.agent.md(content unchanged, binary copy of template source)quality.agent.md— adds two Testing Compliance checklist items (hierarchy boundary and cross-hierarchy dependency checks); movesResultfield explanation to after the report template blockdeveloper.agent.md,implementation.agent.md,repo-consistency.agent.mdStandards Files (
/.github/standards/)coding-principles.md— universal literate coding and architecture principlestesting-principles.md— universal AAA pattern and test dependency boundary rulesSupporting Files
AGENTS.md— binary copy from template;code-reviewreferences replaced withformal-reviewlint.sh/lint.bat— expanded to include dotnet tool restore,reqstream --lint,versionmark --lint,reviewmark --lint, anddotnet restorebeforedotnet formatType of Change
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.BuildMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
All
.github/agents/*.mdand.github/standards/*.mdfiles verified as byte-for-byte identical to the template via git blob SHA comparison.