Fix issues found in formal code reviews of all review-sets

.reviewmark.yaml

@@ -71,40 +71,30 @@ reviews:
     paths:
       - "docs/reqstream/build-mark/cli/cli.yaml"
       - "docs/design/build-mark/cli/cli.md"
-      - "docs/design/build-mark/cli/context.md"
-      - "docs/design/build-mark/program.md"
       - "test/**/Cli/ContextTests.cs"
 
   - id: BuildMark-SelfTest
     title: Review of BuildMark SelfTest subsystem (self-validation)
     paths:
       - "docs/reqstream/build-mark/self-test/self-test.yaml"
       - "docs/design/build-mark/self-test/self-test.md"
-      - "docs/design/build-mark/self-test/validation.md"
       - "test/**/SelfTest/ValidationTests.cs"
 
   - id: BuildMark-Utilities
     title: Review of BuildMark Utilities subsystem (shared utilities)
     paths:
       - "docs/reqstream/build-mark/utilities/utilities.yaml"
       - "docs/design/build-mark/utilities/utilities.md"
-      - "docs/design/build-mark/utilities/path-helpers.md"
       - "test/**/Utilities/PathHelpersTests.cs"
 
   - id: BuildMark-RepoConnectors
     title: Review of BuildMark RepoConnectors subsystem (repository connectors)
     paths:
-      - "docs/reqstream/build-mark/repo-connectors/repo-connectors.yaml"           # subsystem requirements
-      - "docs/design/build-mark/repo-connectors/repo-connectors.md"                # subsystem design
-      - "docs/design/build-mark/repo-connectors/github-repo-connector.md"          # GitHubRepoConnector unit design
-      - "src/**/RepoConnectors/IRepoConnector.cs"                                  # connector interface
-      - "src/**/RepoConnectors/RepoConnectorBase.cs"                               # connector base class
-      - "src/**/RepoConnectors/RepoConnectorFactory.cs"                            # connector factory
-      - "src/**/RepoConnectors/MockRepoConnector.cs"                               # mock connector
-      - "src/**/RepoConnectors/ProcessRunner.cs"                                   # process runner
-      - "test/**/RepoConnectors/MockRepoConnectorTests.cs"                         # mock connector tests
-      - "test/**/RepoConnectors/ProcessRunnerTests.cs"                             # process runner tests
-      - "test/**/RepoConnectors/RepoConnectorFactoryTests.cs"                      # factory tests
+      - "docs/reqstream/build-mark/repo-connectors/repo-connectors.yaml"
+      - "docs/design/build-mark/repo-connectors/repo-connectors.md"
+      - "test/**/RepoConnectors/MockRepoConnectorTests.cs"
+      - "test/**/RepoConnectors/ProcessRunnerTests.cs"
+      - "test/**/RepoConnectors/RepoConnectorFactoryTests.cs"
 
   - id: BuildMark-Architecture
     title: Review of BuildMark system-level behavior and integration

src/DemaConsulting.BuildMark/RepoConnectors/GitHub/GitHubGraphQLClient.cs

@@ -54,18 +54,26 @@ public GitHubGraphQLClient(string token, string? graphqlEndpoint = null)
     {
         // Initialize HTTP client with authentication and user agent headers
         var httpClient = new HttpClient();
-        httpClient.DefaultRequestHeaders.Authorization =
-            new AuthenticationHeaderValue("Bearer", token);
-        httpClient.DefaultRequestHeaders.UserAgent.Add(
-            new ProductInfoHeaderValue("BuildMark", "1.0"));
+        try
+        {
+            httpClient.DefaultRequestHeaders.Authorization =
+                new AuthenticationHeaderValue("Bearer", token);
+            httpClient.DefaultRequestHeaders.UserAgent.Add(
+                new ProductInfoHeaderValue("BuildMark", "1.0"));
 
-        // Create GraphQL HTTP client with the configured HTTP client
-        var options = new GraphQLHttpClientOptions
+            // Create GraphQL HTTP client with the configured HTTP client
+            var options = new GraphQLHttpClientOptions
+            {
+                EndPoint = new Uri(graphqlEndpoint ?? DefaultGitHubGraphQLEndpoint)
+            };
+            _graphqlClient = new GraphQLHttpClient(options, new SystemTextJsonSerializer(), httpClient);
+            _ownsGraphQLClient = true;
+        }
+        catch
         {
-            EndPoint = new Uri(graphqlEndpoint ?? DefaultGitHubGraphQLEndpoint)
-        };
-        _graphqlClient = new GraphQLHttpClient(options, new SystemTextJsonSerializer(), httpClient);
-        _ownsGraphQLClient = true;
+            httpClient.Dispose();
+            throw;
+        }
     }
 
     /// <summary>

src/DemaConsulting.BuildMark/RepoConnectors/GitHubRepoConnector.cs

@@ -846,7 +846,7 @@ private static string GetTypeFromLabels(IReadOnlyList<IssueLabelInfo> labels)
         var matchingType = labels
             .Select(label => label.Name.ToLowerInvariant())
             .SelectMany(lowerLabel => LabelTypeMap
-                .Where(kvp => lowerLabel.Contains(kvp.Key))
+                .Where(kvp => lowerLabel == kvp.Key)
                 .Select(kvp => kvp.Value))
             .FirstOrDefault();
 
@@ -865,7 +865,7 @@ private static string GetTypeFromLabels(IReadOnlyList<PullRequestLabelInfo> labe
         var matchingType = labels
             .Select(label => label.Name.ToLowerInvariant())
             .SelectMany(lowerLabel => LabelTypeMap
-                .Where(kvp => lowerLabel.Contains(kvp.Key))
+                .Where(kvp => lowerLabel == kvp.Key)
                 .Select(kvp => kvp.Value))
             .FirstOrDefault();
 

test/DemaConsulting.BuildMark.Tests/SelfTest/ValidationTests.cs

@@ -46,6 +46,8 @@ public void Validation_Run_WithTrxResultsFile_WritesTrxFile()
             using var outputWriter = new StringWriter();
             using var errorWriter = new StringWriter();
 
+            var originalOut = Console.Out;
+            var originalError = Console.Error;
             try
             {
                 // Capture console output
@@ -67,10 +69,8 @@ public void Validation_Run_WithTrxResultsFile_WritesTrxFile()
             finally
             {
                 // Restore console output
-                var standardOutput = new StreamWriter(Console.OpenStandardOutput()) { AutoFlush = true };
-                Console.SetOut(standardOutput);
-                var standardError = new StreamWriter(Console.OpenStandardError()) { AutoFlush = true };
-                Console.SetError(standardError);
+                Console.SetOut(originalOut);
+                Console.SetError(originalError);
             }
         }
         finally
@@ -101,6 +101,8 @@ public void Validation_Run_WithXmlResultsFile_WritesJUnitFile()
             using var outputWriter = new StringWriter();
             using var errorWriter = new StringWriter();
 
+            var originalOut = Console.Out;
+            var originalError = Console.Error;
             try
             {
                 // Capture console output
@@ -122,10 +124,8 @@ public void Validation_Run_WithXmlResultsFile_WritesJUnitFile()
             finally
             {
                 // Restore console output
-                var standardOutput = new StreamWriter(Console.OpenStandardOutput()) { AutoFlush = true };
-                Console.SetOut(standardOutput);
-                var standardError = new StreamWriter(Console.OpenStandardError()) { AutoFlush = true };
-                Console.SetError(standardError);
+                Console.SetOut(originalOut);
+                Console.SetError(originalError);
             }
         }
         finally