Pass --no-sanitize-env to cargo-lipo #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it clears IPHONEOS_DEPLOYMENT_TARGET variable and core gets built for wrong iOS version instead of 12.0.
|
the PR works for me on core v1.136.6 (yeah, makes sense to get the script out of Xcode :), will try the commit that reproduces the warnings in #2104 now |
r10s
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
yeah, works like a charm, i could build https://github.com/deltachat/deltachat-core-rust/tree/0be8b5a5c44ab8b4c3f48c4746de8cf947389a6a from #2104 with zero warnings (tried simulator)
great job, thanks A LOT for figuring that out!
|
when trying to build core main-branch, however, i get another error (not warning), this is probably independent from #2104 and this PR, will double check and file a new issue as needed |
|
I also got some problems with |
|
i filed an issue for the new error at #2144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2142
Fixes #2104