Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Rust 1.77.0 support for recursion in async functions #5369

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Mar 22, 2024

Postponed at least until GitHub actions runners are updated to 1.77.0. We also need to bump toolchains used to build Android and iOS to 1.77 first.

@link2xt link2xt force-pushed the link2xt/recursive-async branch from 4a177ea to 68fac9c Compare March 23, 2024 00:30
@r10s
Copy link
Member

r10s commented Mar 23, 2024

We also need to bump toolchains used to build Android and iOS to 1.77 first.

maybe wait until @zeitschlag and @adbenitez confirm that things work for them as well, but in general, it looks good :)

@link2xt
Copy link
Collaborator Author

link2xt commented Mar 23, 2024

1.77 is not in the runner images, but promised in the next update: actions/runner-images#9547 (comment)

@link2xt link2xt force-pushed the link2xt/recursive-async branch 2 times, most recently from d9ce2a9 to abad241 Compare April 3, 2024 21:55
@link2xt link2xt marked this pull request as ready for review April 3, 2024 21:56
@link2xt link2xt marked this pull request as draft April 4, 2024 08:37
@link2xt
Copy link
Collaborator Author

link2xt commented Apr 4, 2024

macos-latest runners still have Rust 1.76. Badge at https://github.com/actions/runner-images says "deploying", once it is deployed we should have Rust 1.77 there.

@link2xt link2xt force-pushed the link2xt/recursive-async branch from abad241 to 745fffd Compare April 4, 2024 16:37
@link2xt link2xt marked this pull request as ready for review April 4, 2024 16:59
@link2xt link2xt force-pushed the link2xt/recursive-async branch from 745fffd to 49b81c7 Compare April 4, 2024 17:00
@link2xt link2xt force-pushed the link2xt/recursive-async branch from 49b81c7 to 2f0f247 Compare April 4, 2024 17:01
@link2xt link2xt merged commit 2f0f247 into main Apr 4, 2024
10 checks passed
@link2xt link2xt deleted the link2xt/recursive-async branch April 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants