Remove vg-request-with-auth from IMAP after processing
#6208
Assignees
Comments
Probably because it's a common code for the "verified groups" and "verified contacts" setup protocols. Yes, it seems that |
iequidoo
added a commit
that referenced
this issue
Dec 21, 2024
In multi-device case `vg-request-with-auth` left on IMAP may result in situation when Bob joins the group, then leaves it, then second Alice device comes online and processes `vg-request-with-auth` again and adds Bob back. So we should IMAP-delete `vg-request-with-auth`. Another device will know the Bob's key from Autocrypt-Gossip. But also we should make sure that `vg-member-added` is sent before that. For this, add a new `imap.target_min_smtp_id` column and only move or delete emails when `smtp.id` reaches the `imap.target_min_smtp_id` value.
iequidoo
added a commit
that referenced
this issue
Dec 22, 2024
In multi-device case `vg-request-with-auth` left on IMAP may result in situation when Bob joins the group, then leaves it, then second Alice device comes online and processes `vg-request-with-auth` again and adds Bob back. So we should IMAP-delete `vg-request-with-auth`. Another device will know the Bob's key from Autocrypt-Gossip. But also we should make sure that `vg-member-added` is sent before that. For this, add a new `imap.target_min_smtp_id` column and only move or delete emails when `smtp.id` reaches the `imap.target_min_smtp_id` value.
iequidoo
added a commit
that referenced
this issue
Dec 22, 2024
In multi-device case `vg-request-with-auth` left on IMAP may result in situation when Bob joins the group, then leaves it, then second Alice device comes online and processes `vg-request-with-auth` again and adds Bob back. So we should IMAP-delete `vg-request-with-auth`. Another device will know the Bob's key from Autocrypt-Gossip. But also we should make sure that `vg-member-added` is sent before that. For this, add a new `imap.target_min_smtp_id` column and only move or delete emails when `smtp.id` reaches the `imap.target_min_smtp_id` value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Alice currently does not remove the message from IMAP for some reason stated in the comment:
deltachat-core-rust/src/securejoin.rs
Line 473 in e7a29f0
In multi-device case this may result in situation when Bob join the group, then leaves it, then second Alice device comes online and processes
vg-request-with-authagain and adds Bob back.I don't see why Autocrypt header is needed by the second device, Alice should see self-sent "member added" message and take gossiped Bob's key from there.
This is a follow-up to #5356
The text was updated successfully, but these errors were encountered: