Multiplex HTTPS, IMAP and SMTP on port 443 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related Delta Chat core PR making it request |
link2xt
force-pushed
the
link2xt/stream-alpn-proxy
branch
from
5abb52f
to
a57619d
Compare
link2xt
force-pushed
the
link2xt/stream-alpn-proxy
branch
3 times, most recently
from
13fec29
to
b5cd2ac
Compare
hpk42
reviewed
Jul 11, 2024
| map $ssl_preread_alpn_protocols $proxy { | ||
| default 127.0.0.1:8443; | ||
| ~\bsmtp\b 127.0.0.1:465; | ||
| ~\bimap\b 127.0.0.1:993; |
There was a problem hiding this comment.
does this mean that establishing SSL is done by imap/postfix still?
There was a problem hiding this comment.
Yes, it is controlled by proxy_ssl which is off by default. Passing to plaintext port would not work, I think postfix and dovecot would not be happy about authentication before STARTTLS.
hpk42
reviewed
Jul 11, 2024
Comment on lines
16
to
17
| ~\bsmtp\b 127.0.0.1:465; | ||
| ~\bimap\b 127.0.0.1:993; |
There was a problem hiding this comment.
can we use the /etc/service names of "imaps" and "smtps" here? i'd prefer that.
link2xt
force-pushed
the
link2xt/stream-alpn-proxy
branch
from
b5cd2ac
to
10bf9d5
Compare
Services are distinguished based on ALPN.
For example,
openssl s_client -connect example.org:443 -alpn smtp
gives SMTP connection and
openssl s_client -connect example.org:443 -alpn imap
gives IMAP connection.
link2xt
force-pushed
the
link2xt/stream-alpn-proxy
branch
from
10bf9d5
to
4a8ceaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services are distinguished based on ALPN.
For example,
openssl s_client -connect example.org:443 -alpn smtp
gives SMTP connection and
openssl s_client -connect example.org:443 -alpn imap
gives IMAP connection.