[Spark] Use condition instead of errorClass in checkError()#3680
Merged
vkorukanti merged 5 commits intodelta-io:masterfrom Sep 18, 2024
Merged
[Spark] Use condition instead of errorClass in checkError()#3680vkorukanti merged 5 commits intodelta-io:masterfrom
condition instead of errorClass in checkError()#3680vkorukanti merged 5 commits intodelta-io:masterfrom
Conversation
condition instead of errorClass in checkError()condition instead of errorClass in checkError()
Contributor
Author
|
@cloud-fan Could you have a look at the PR, please. It fixes compilation issues. |
Contributor
|
I think Delta master branch needs to cross-compile with both Spark master and 3.5 branches. We should create a shim layer for |
Contributor
Author
@cloud-fan As an alternative solution, we could pass the first two arguments protected def checkError(
exception: SparkThrowable,
condition: String, |
Contributor
Author
|
@cloud-fan Compilation has been fixed. The failed tests are not related to my changes, I hope. |
cloud-fan
approved these changes
Sep 18, 2024
vkorukanti
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
In the PR, I propose to use the
conditionparameter instead oferrorClassin calls ofcheckErrorbecauseerrorClasswas renamed in Spark by the PR apache/spark#48027. This PR fixes compilation issues like:How was this patch tested?
By compiling locally.
Does this PR introduce any user-facing changes?
No. This makes changes in tests only.