Skip to content

[Build] Fix Java checkstyle plugin to work with SBT upgrade #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allisonport-db merged 3 commits into from
May 3, 2024
Merged

[Build] Fix Java checkstyle plugin to work with SBT upgrade #3019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fde9c6e
upgrade versions
allisonport-db May 1, 2024
720a8fb
Actually fail compile/test correctly
allisonport-db May 2, 2024
a632bd5
Fix flink checkstyle
allisonport-db May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ def javaCheckstyleSettings(checkstyleFile: String): Def.SettingsDefinition = {
// and during tests (e.g. build/sbt test)
Seq(
checkstyleConfigLocation := CheckstyleConfigLocation.File(checkstyleFile),
checkstyleSeverityLevel := Some(CheckstyleSeverityLevel.Error),
checkstyleSeverityLevel := CheckstyleSeverityLevel.Error,
(Compile / checkstyle) := (Compile / checkstyle).triggeredBy(Compile / compile).value,
(Test / checkstyle) := (Test / checkstyle).triggeredBy(Test / compile).value
)
Expand Down
4 changes: 2 additions & 2 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % VersionSch

addSbtPlugin("net.aichler" % "sbt-jupiter-interface" % "0.9.1")

addSbtPlugin("com.etsy" % "sbt-checkstyle-plugin" % "3.1.1")
addSbtPlugin("software.purpledragon" % "sbt-checkstyle-plugin" % "4.0.1")
// By default, sbt-checkstyle-plugin uses checkstyle version 6.15, but we should set it to use the
// same version as Spark
dependencyOverrides += "com.puppycrawl.tools" % "checkstyle" % "8.43"
dependencyOverrides += "com.puppycrawl.tools" % "checkstyle" % "9.3"