Skip to content

[DO_NOT_MERGE] Start addressing necessary changes to support Spark 4.0#2672

Open
allisonport-db wants to merge 27 commits intodelta-io:masterfrom
allisonport-db:spark-4.0-upgrade
Open

[DO_NOT_MERGE] Start addressing necessary changes to support Spark 4.0#2672
allisonport-db wants to merge 27 commits intodelta-io:masterfrom
allisonport-db:spark-4.0-upgrade

Conversation

@allisonport-db
Copy link
Contributor

@allisonport-db allisonport-db commented Feb 22, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Builds delta-spark using the published snapshots for the current Spark master in preparation for the Spark 4.0 release.

Compilation and test fixes.

Spark fixes so far

How was this patch tested?

[IN PROGRESS]

@allisonport-db allisonport-db force-pushed the spark-4.0-upgrade branch 2 times, most recently from 1ab6722 to c538538 Compare March 4, 2024 21:55
@felipepessoto
Copy link
Contributor

felipepessoto commented Mar 5, 2024

In Spark CI they use Python 3.9: https://github.com/apache/spark/blob/73aa144666834c4fc2af29a57149afe36be08fcc/.github/workflows/build_and_test.yml#L243

https://github.com/ahshahid/spark/actions/runs/8105986308/job/22155227446:
image

Do you think we can consider this PR to make things easier for folks running Delta tests with Python 3.9? https://github.com/delta-io/delta/pull/2353/files

It doesn't break Python 3.8 used by this repo

Thanks.

allisonport-db and others added 21 commits March 5, 2024 10:07
GitOrigin-RevId: a917005aecfa72bc70a6414b675cd54ee548aa96
GitOrigin-RevId: dcfbc81ff53f26f4ec79ba52074c6f469928abf6
GitOrigin-RevId: 2fd73b5fe81d32fcb121ee36ff779b51c3441909
GitOrigin-RevId: 6eea012effffbb4d4f028385da890945f5bbdda2
GitOrigin-RevId: c6795716ca812eedecfdba07a72718432ae3d494
GitOrigin-RevId: d57235dc0d25247035cbfea5c05d5b0c533338fd
GitOrigin-RevId: fbe3747c7e71180f4b586fbfa74c9bc2489c4850
GitOrigin-RevId: 142b3b1b89003f6af4b061f0b8de2d0452570a3d
GitOrigin-RevId: fa79d744dde841bf6addf72fcd22be4d7b3a9d11
GitOrigin-RevId: db1f2f36a6e5f160c77d5ff00d8b946c734afc56
GitOrigin-RevId: a5a2a9927ab5a2a1b8671389dea5742d43f65bc9
GitOrigin-RevId: 25b154d097966d5d2541243bcfd5c1d90bedab38
GitOrigin-RevId: ecd9c7204e4000526db1aaf0e220d1db38a67887
Comment on lines +34 to +40
message: String,
line: Option[Int] = None,
startPosition: Option[Int] = None,
cause: Option[Throwable] = None,
errorClass: Option[String] = None,
messageParameters: Array[String] = Array.empty,
context: Array[QueryContext] = Array.empty)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants