Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new session name on assume role credentials provider refresh #451

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

mosyp
Copy link
Contributor

@mosyp mosyp commented Oct 8, 2021

The default autorefresh rusoto provider uses cached session name between assume role requests. This could cause trouble if there's more than one active sessions. In order to prevent conflicts, we should generate the new session name for each assume role request

@mosyp mosyp requested review from xianwill and houqp October 8, 2021 15:56
@mosyp mosyp merged commit 2800078 into delta-io:main Oct 11, 2021
@mosyp mosyp deleted the refresh_sts_session_name branch October 11, 2021 08:48
@mosyp
Copy link
Contributor Author

mosyp commented Oct 11, 2021

@xianwill Another possible fix could be to lower the rusoto/hyper idle timeout as in hyperium/hyper#2136 (comment).

At first I thought that creating "new" client with fresh session name could help, but now it seems that simply StsClient::new(self.region.clone()) is a reuse for Client::shared() so the client stays the same, and if the issue is really in idle connection (which could be the case, since credentials are executed once in 30min), then we might try this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants