Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of black, isort, mypy tools usages into pyproject.toml #378

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Refactoring of black, isort, mypy tools usages into pyproject.toml #378

merged 1 commit into from
Aug 12, 2021

Conversation

fvaleye
Copy link
Collaborator

@fvaleye fvaleye commented Aug 11, 2021

Description

  • Refactoring of Python black, isort and mypy tools inside pyproject.toml
  • Add stubs for mypy
  • Add pytest-clarify to improve the output of the tests suite results in Python

@fvaleye fvaleye added the binding/python Issues for the Python package label Aug 11, 2021
@fvaleye fvaleye enabled auto-merge (squash) August 11, 2021 17:08
@fvaleye fvaleye force-pushed the refactoring/python-dev-experience branch from 4e13f51 to 916d895 Compare August 11, 2021 17:10
houqp
houqp approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

python/stubs/deltalake/deltalake.pyi
from typing import Any

RawDeltaTable: Any
rust_core_version: Any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could annotate this as a callable that returns a str

@fvaleye fvaleye merged commit f552cae into delta-io:main Aug 12, 2021
@fvaleye fvaleye mentioned this pull request Aug 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houqp houqp houqp approved these changes

Assignees
No one assigned
Labels
binding/python Issues for the Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvaleye @houqp