-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rust): bump arrow v51 and datafusion v37.1 #2395
Conversation
@ion-elgreco I've fixed It seems that the expression should have been rewritten, but I'm not sure how or where. |
@lasantosr I dont know where this error is coming from. Likely something needs to be refactored, you could ask the datafusion devs if they have any hints |
It seems it have something to do with apache/datafusion#9532, but I've just started using delta a few weeks ago, so I'm not sure if I can help here. |
@lasantosr I'll take a look over the weekend |
@lasantosr hey, I have taken a look but I don't see any issue. It seemed to have been a regression in datafusion, see here: apache/datafusion#10029 We have to wait on the 37.1.0 release apache/datafusion#9904 |
@ion-elgreco Thanks! That regression wasn't detected when I made the PR. I can keep an eye on the 37.1.0 release and update this PR as soon as it lands. |
@lasantosr to get this merged, we need to follow Andrews advice, and manually convert this Expr: apache/datafusion#10181 (comment) If it's not crucial, we also can wait for datafusion 38 |
@ion-elgreco I've included a temporary fix with a TODO in order to remove it in v38 when the fix is ported back to datafusion core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with it! 😁
Description
Update the arrow and datafusion dependencies.
Related Issue(s)
Documentation