Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): bump arrow v51 and datafusion v37.1 #2395

Merged
merged 11 commits into from
Apr 26, 2024

Conversation

lasantosr
Copy link
Contributor

Description

Update the arrow and datafusion dependencies.

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Apr 7, 2024
@lasantosr
Copy link
Contributor Author

@ion-elgreco I've fixed test_expr_sql, but test_delete_nested is still failing

It seems that the expression should have been rewritten, but I'm not sure how or where.

@ion-elgreco
Copy link
Collaborator

@lasantosr I dont know where this error is coming from. Likely something needs to be refactored, you could ask the datafusion devs if they have any hints

@lasantosr
Copy link
Contributor Author

It seems it have something to do with apache/datafusion#9532, but I've just started using delta a few weeks ago, so I'm not sure if I can help here.

@ion-elgreco
Copy link
Collaborator

@lasantosr I'll take a look over the weekend

@ion-elgreco
Copy link
Collaborator

@lasantosr hey, I have taken a look but I don't see any issue. It seemed to have been a regression in datafusion, see here: apache/datafusion#10029

We have to wait on the 37.1.0 release apache/datafusion#9904

@ion-elgreco ion-elgreco added the on-hold Issues and Pull Requests that are on hold for some reason label Apr 16, 2024
@lasantosr
Copy link
Contributor Author

@ion-elgreco Thanks! That regression wasn't detected when I made the PR.

I can keep an eye on the 37.1.0 release and update this PR as soon as it lands.

@rtyler rtyler marked this pull request as ready for review April 22, 2024 02:54
@ion-elgreco ion-elgreco changed the title chore(rust): bump arrow v51 and datafusion v37 chore(rust): bump arrow v51 and datafusion v37.1 Apr 22, 2024
@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Apr 26, 2024

@lasantosr to get this merged, we need to follow Andrews advice, and manually convert this Expr: apache/datafusion#10181 (comment)

If it's not crucial, we also can wait for datafusion 38

@lasantosr
Copy link
Contributor Author

@ion-elgreco I've included a temporary fix with a TODO in order to remove it in v38 when the fix is ported back to datafusion core.

Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it! 😁

@ion-elgreco ion-elgreco enabled auto-merge (squash) April 26, 2024 18:13
@ion-elgreco ion-elgreco merged commit 9d3ecbe into delta-io:main Apr 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate on-hold Issues and Pull Requests that are on hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update arrow dependency
3 participants