Skip to content

Commit

Permalink
undo the horrible hack, bump dat version
Browse files Browse the repository at this point in the history
  • Loading branch information
nicklan committed Jul 12, 2024
1 parent 0ef083e commit 040db84
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion acceptance/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use tar::Archive;

const DAT_EXISTS_FILE_CHECK: &str = "tests/dat/.done";
const OUTPUT_FOLDER: &str = "tests/dat";
const VERSION: &str = "0.0.2";
const VERSION: &str = "0.0.3";

fn main() {
if dat_exists() {
Expand Down
10 changes: 0 additions & 10 deletions kernel/src/engine/arrow_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ pub(crate) fn ensure_data_types(
arrow_type: &ArrowDataType,
) -> DeltaResult<()> {
match (kernel_type, arrow_type) {
(DataType::Primitive(PrimitiveType::Timestamp), ArrowDataType::Timestamp(_, _))
| (DataType::Primitive(PrimitiveType::TimestampNtz), ArrowDataType::Timestamp(_, _)) => {
// We assume that any timestamp data read from a delta table is correctly written in
// microseconds and with the right timezone info. there seems to be an issue at least on
// MacOS where the parquet crate reports `Timestamp(Nanoseconds, None)` even though the
// parquet footer indicates `timeUnit=microseconds` and `isAdjustedToUTC=true`. Will
// follow-up upstream to see if this is a bug in the parquet crate.
// TODO: FILL IN ISSUE NUMBER(s)
Ok(())
}
(DataType::Primitive(_), _) if arrow_type.is_primitive() => {
let converted_type: ArrowDataType = kernel_type.try_into()?;
if &converted_type == arrow_type {
Expand Down

0 comments on commit 040db84

Please sign in to comment.