Fixes #96 dvp init hitting TypeError on Windows10

[muralinimmagadda]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build was run locally and any changes were pushed
• Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

dvp init -s staged fails on windows

Issue Number: 96

What is the new behavior?

dvp init -s staged successful on windows

Does this introduce a breaking change?

• Yes
• No

Other information

[muralinimmagadda]

dvp init -s STAGED is failing with following error.

File "c:\murali\venv\lib\site-packages\click\types.py", line 187, in convert
normed_value = lower(normed_value)
TypeError: descriptor 'lower' requires a 'str' object but received a 'unicode'

The error is thrown at line 187 of the below file and looks like a bug in click 7.1 code. https://github.com/pallets/click/blob/7.x/src/click/types.py

The problem is in this part of their code where normed_value is a unicode value and they are calling str.lower() on it.

def convert(self, value, param, ctx):
# Match through normalization and case sensitivity
# first do token_normalize_func, then lowercase
# preserve original value to produce an accurate message in
# self.fail
normed_value = value
normed_choices = {choice: choice for choice in self.choices}

    if ctx is not None and ctx.token_normalize_func is not None:
        normed_value = ctx.token_normalize_func(value)
        normed_choices = {
            ctx.token_normalize_func(normed_choice): original
            for normed_choice, original in normed_choices.items()
        }

    if not self.case_sensitive:
        if PY2:
            lower = str.lower
        else:
            lower = str.casefold

        normed_value = lower(normed_value)
        normed_choices = {
            lower(normed_choice): original
            for normed_choice, original in normed_choices.items()
        }

Removing case_sensitive=False on init method of cli.py can bypass this but it introduces the change of behaviour for -s staged vs -s STAGED. So, instead of changing this, i added token_normalize_func() that converts unicode to a string type so that normed_value = ctx.token_normalize_func(value) can modify it to a string type before the call to lower() that was failing this happens.

[ankursarin]

looks good. ship it!

[muralinimmagadda]

@zach-burke ran blackbox tests with the fix : http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/34202/consoleFull

The failures are not related to this fix. so we are good to go.