PYT-1103 No error displayed by the dvp upload command when file upload job fails #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffngo
requested review from
ankursarin,
fdrozdowski,
mothslaw,
muralinimmagadda,
nhlien93 and
ravi-cm
nhlien93
reviewed
Mar 11, 2020
Contributor
nhlien93
left a comment
nhlien93
left a comment
There was a problem hiding this comment.
took a quick pass, I'll try to look again in a bit! looks overall good though.
tools/src/main/python/dlpx/virtualization/_internal/delphix_client.py
Outdated
Show resolved
Hide resolved
tools/src/test/python/dlpx/virtualization/_internal/commands/test_build.py
Show resolved
Hide resolved
ravi-cm
requested changes
Mar 11, 2020
tools/src/main/python/dlpx/virtualization/_internal/delphix_client.py
Outdated
Show resolved
Hide resolved
mothslaw
previously approved these changes
Mar 12, 2020
Contributor
mothslaw
left a comment
mothslaw
left a comment
There was a problem hiding this comment.
Looks good. Ship it modulo others' comments.
nhlien93
previously approved these changes
Mar 12, 2020
jeffngo
force-pushed
the
waitForUploadJob
branch
from
832d8c0 to
6cf5dc0
Compare
Contributor
Author
|
Addressed feedback from Lindsey and Ravi. Added new formatting to the command after discussions with QA. |
ravi-cm
approved these changes
Mar 12, 2020
mothslaw
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The dvp upload command issues an upload job to a Delphix Engine but does not wait for the upload to complete before returning. This can be problematic for both testing and end-users since we can't tell whether the upload job finished successfully or not.
What is the new behavior?
Introduce a wait flag in the dvp upload command that waits for the upload job to complete. We query the upload action and job every 5 seconds until the job succeeds, fails, or times out (60 min).
Does this introduce a breaking change?
Other information