Merge Gitlab's master branch into GitHub's develop branch #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat with decorators on build Reviewed at: http://reviews.delphix.com/r/53996/
PYT-973 PluginImporter/Validator does not fail when an unexpected error is raised inside the Process Reviewed at: http://reviews.delphix.com/r/54495/
…ema_validator modules Reviewed at: http://reviews.delphix.com/r/54844/
…plugin validator/imported code Reviewed at: http://reviews.delphix.com/r/54864/
… util_classes.py and fix any circular dependencies in plugin validator/imported code Reviewed at: http://reviews.delphix.com/r/55097/
PYT-837 Plugin Versioning - New build number field should be added on init Reviewed at: http://reviews.delphix.com/r/55151/
…kbox changes Reviewed at: http://reviews.delphix.com/r/55287/
…nordered dictionary Reviewed at: http://reviews.delphix.com/r/55262/
PYT-831 Multi-step Upgrade - Invoke upgrade migration functions from upgrade wrappers Reviewed at: http://reviews.delphix.com/r/55381/
…d make optional Reviewed at: http://reviews.delphix.com/r/55561/
… properties Reviewed at: http://reviews.delphix.com/r/55896/
fdrozdowski
requested review from
ankursarin,
jeffngo,
mothslaw,
nhlien93 and
ravi-cm
Contributor
|
the merge looks correct but could you re run the blackbox runs and make sure you have the right extra params? seems like something went wrong with all the tests. Also maybe run a windows test too for sanity? |
ankursarin
previously approved these changes
Mar 3, 2020
Contributor
ankursarin
left a comment
ankursarin
left a comment
There was a problem hiding this comment.
Ship it! assuming all bb tests pass
nhlien93
previously approved these changes
Mar 3, 2020
Contributor
nhlien93
left a comment
nhlien93
left a comment
There was a problem hiding this comment.
once backbox tests pass.
…lated changes Reviewed at: http://reviews.delphix.com/r/56374/
…ithub PYT-1095 Bump up API version in SDK to support new backend upgrade related changes
fdrozdowski
dismissed stale reviews from nhlien93, ankursarin, and muralinimmagadda
via
eed8f57
muralinimmagadda
approved these changes
Mar 4, 2020
nhlien93
approved these changes
Mar 4, 2020
Contributor
Author
|
@nhlien93 Just updated links to blackbox tests in the description. They all passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
One team has been developing on a private Gitlab repository while the other team has been developing on GitHub. This was temporary while we've been preparing the GitHub repository to have all the processes in place (pre-commit GitHub action).
What is the new behavior?
The development of the SDK will be only happening on GitHub.
Does this introduce a breaking change?
The changes that are merged from the Gitlab master's branch have introduced a breaking API change and hence the SDK version was bumped from 1.1.0 to 2.0.0.
Other information
appdata_sanity (nix_staged_python): http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/25366/consoleFull (PASSED)
appdata_python_samples: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/25368/consoleFull (PASSED)
virtualization_sdk (ubuntu 18 sdk host): http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/25361/consoleFull (PASSED)