-
Notifications
You must be signed in to change notification settings - Fork 27
DLPX-84163 Update all the greater than equal to (>=) dependencies in setup.py and requirements.txt files of dvp packages to equal to(==) #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrLiber
approved these changes
Jan 17, 2023
PiyushPGuptaG
approved these changes
Jan 23, 2023
vimleshmishra
approved these changes
Jan 30, 2023
This was referenced Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There are around 40 PRs opened by dependentBot to bump up the dependencies version. Also, some dependencies in our setup.py uses
>=dependencies for exampleflake8 >= 3.6which can cause some unknown errors in case dependencies releases a new version.Problem
Recently, flake8 released 6.0.0 version which started causing
dvp buildto fail with'Manager' object has no attribute 'checkers', as flake8 6.0.0 has made changes to manager package.Evaluation
The exact cause of the issue is
plugin_validator.pyintoolspackage (line no. 213) where we try to accesscheckersobject @style_guide._application.file_checker_manager.checkers.As flake8 6.0.0 has removed
checkersand started usingresultobject, the issue occurred.Solution
>=to>=, <or==in setup.py files of all packages.plugin_validator.pyto sync with flake8 changes.Testing Done
appdata_python_samples
appdata_basic
virtualization_sdk
Bonus
Dependency Tree for dvp 4.0.5 install
Dependency Tree for local changes install
Diff of Pip Freeze