Merge docs/3.0.0 with develop and Add CNAME to publish-docs (#319)#336
Merged
jeffngo merged 1 commit intodelphix:developfrom Feb 9, 2021
Merged
Merge docs/3.0.0 with develop and Add CNAME to publish-docs (#319)#336jeffngo merged 1 commit intodelphix:developfrom
jeffngo merged 1 commit intodelphix:developfrom
Conversation
Virtualization SDK Docs - Virtual Source Initialize (delphix#316)
mothslaw
approved these changes
Feb 9, 2021
ankursarin
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtualization SDK Docs - Virtual Source Initialize (#316)
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
Add CNAME to publish-docs when pushing to delphix/virtualization-sdk
What is the current behavior?
Issue Number: 319
What is the new behavior?
When the release lead pushes to a docs/** branch, kick off github actions if any changes were made to the .yml file itself (to test the new code in the github action). In addition, only create a CNAME file when publishing the docs to gh-pages to the delphix/virtualization repository. The reason for this is because the CNAME file contains the URL for our documentation (developer.delphix.com) and pushing the CNAME file will fail the github action since the domain is already in use.
Does this introduce a breaking change?
Other information