Skip to content

Conversation

@jeffngo
Copy link
Contributor

@jeffngo jeffngo commented Jan 7, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Version Change

What is the current behavior?

Issue Number: 303

What is the new behavior?

  • Changed the Virtualization SDK version to post release format

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jeffngo jeffngo added this to the VSDK Sprint 1/7-1/28 milestone Jan 7, 2021
@jeffngo jeffngo self-assigned this Jan 7, 2021
Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tools package is missing a version bump?
Did bumpversion skip changing that?

Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more file is missing - tools/src/main/python/dlpx/virtualization/_internal/VERSION?

@jeffngo
Copy link
Contributor Author

jeffngo commented Jan 8, 2021

I think the tools package is missing a version bump?
Did bumpversion skip changing that?

Nope. I couldn't find a good way to bump the dev build from prod earlier when I submitted the PR. Ended up bumping these versions manually on this PR. Just found out that the correct way of doing this from a prod release format would be to run bumpversion minor which would bump 3.0.0 to 3.1.0.dev0.

Copy link
Contributor

@nhlien93 nhlien93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know for a fact that the next version will be a minor version bumb? or maybe this doesn't even matter because we can always change it?

@jeffngo
Copy link
Contributor Author

jeffngo commented Jan 11, 2021

Do we know for a fact that the next version will be a minor version bumb? or maybe this doesn't even matter because we can always change it?

Yeah, we don't know for sure but given that we will be releasing a major version this month, it seems more likely that the next version is going to be a minor version. And if things ever change, we could always change it, of course.

@jeffngo jeffngo merged commit e297d96 into delphix:develop Jan 12, 2021
jeffngo added a commit to jeffngo/virtualization-sdk that referenced this pull request Jan 20, 2021
jeffngo added a commit to jeffngo/virtualization-sdk that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants