-
Notifications
You must be signed in to change notification settings - Fork 27
Bump Virtualization SDK to post release format on develop #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ankursarin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tools package is missing a version bump?
Did bumpversion skip changing that?
ravi-cm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more file is missing - tools/src/main/python/dlpx/virtualization/_internal/VERSION?
Nope. I couldn't find a good way to bump the dev build from prod earlier when I submitted the PR. Ended up bumping these versions manually on this PR. Just found out that the correct way of doing this from a prod release format would be to run |
nhlien93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know for a fact that the next version will be a minor version bumb? or maybe this doesn't even matter because we can always change it?
Yeah, we don't know for sure but given that we will be releasing a major version this month, it seems more likely that the next version is going to be a minor version. And if things ever change, we could always change it, of course. |
…lphix#304)" This reverts commit e297d96.
…lphix#304)" This reverts commit e297d96.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: 303
What is the new behavior?
Does this introduce a breaking change?
Other information