Skip to content

Conversation

@ankursarin
Copy link
Contributor

@ankursarin ankursarin commented Jul 13, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A
Also closes #200

What is the new behavior?

Docs can be reviewed at https://ankursarin.github.io/virtualization-sdk/Building_Your_First_Plugin/Initial_Setup/

  • Standardize on Lua (instead of lua)
  • Standardize on Python (instead of python)
  • Fix a broken link in docs/docs/Best_Practices/Sensitive_Data.md
  • Fix a broken "note" in docs/docs/Best_Practices/Sensitive_Data.md (it was not being encoded as a note due to incorrect spacing)
  • Replaced "contact Delphix Support" with "contact the Delphix Virtualization SDK Engineering team" in docs/docs/Versioning_And_Upgrade/Lua_Toolkit_To_SDK_Plugin_Migration/Overview.md
  • Replaced Sanity Check with Quick Check in Initial_Setup.md
  • Some minor re-wording.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ankursarin ankursarin marked this pull request as ready for review July 13, 2020 21:04
@ankursarin ankursarin added this to the VSDK Sprint 7/2-7/23 milestone Jul 13, 2020
@ankursarin ankursarin merged commit c0a0055 into delphix:release/2.1.0 Jul 13, 2020
@fdrozdowski fdrozdowski linked an issue Aug 12, 2020 that may be closed by this pull request
@ankursarin ankursarin deleted the sdk210docs branch February 16, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

SDK 2.1.0 Release tasks

3 participants