-
Notifications
You must be signed in to change notification settings - Fork 27
Fixes #73 CI/CD: Write release GH Action: publish docs #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2b87ad to
65dd138
Compare
mothslaw
approved these changes
Jun 24, 2020
83ed649 to
d6d835b
Compare
ankursarin
reviewed
Jun 30, 2020
ankursarin
reviewed
Jun 30, 2020
ankursarin
reviewed
Jun 30, 2020
ankursarin
reviewed
Jun 30, 2020
ankursarin
reviewed
Jun 30, 2020
ankursarin
reviewed
Jun 30, 2020
ankursarin
suggested changes
Jun 30, 2020
Contributor
ankursarin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks for setting this up
d17e3ab to
ba0777d
Compare
ba0777d to
299bb9c
Compare
ankursarin
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
GitHub action for building and publishing documentation to GitHub Pages.
What is the current behavior?
Currently, we have to check out the latest documentation branch, build the documentation, and publish the static contents to the
gh-pagesbranch.What is the new behavior?
We introduce a new GitHub workflow that is kicked off on any
docs/*branch ifdocs/*path has been modified and if adocs/*branch is created. The workflow checks if the branch it's running on is the latest documentation branch (docs/x.y.z where x.y.z is the highest available version). If that check passes, we installpipenv, install the dependencies for building documentation, build the documentation, and publish the static contents to thegh-pagesbranch.The reason we only want to run the workflow on the latest docs branch is because we only have one publishing context. We can only publish one version of the documentation using GitHub pages so we only publish the latest version.
You can see a preview of commits created by this workflow under https://github.com/fdrozdowski/virtualization-sdk/tree/gh-pages. They are all entitled " Deploy to gh-pages 🚀 ".
Does this introduce a breaking change?
Other information