Fixes #171 Update API in build from 1.11.2 to 1.11.3 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhlien93
requested review from
ankursarin,
fdrozdowski and
mothslaw
as code owners
fdrozdowski
approved these changes
Jun 17, 2020
ravi-cm
approved these changes
Jun 22, 2020
Contributor
ravi-cm
left a comment
ravi-cm
left a comment
There was a problem hiding this comment.
Should the current_version be 2.1.0 or 2.1.0.dev3? Or once we finish the release it is set to 2.1.0?
jeffngo
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
Updating the engine api used to be 1.11.3 instead of 1.11.2
What is the current behavior?
when running with 1.11.2 api technically the luaName/minimumLuaVersion is ignored in the api, but gets passed all the way through anyways so works. but we want to use the right api.
Issue Number: N/A
What is the new behavior?
Will use the correct engine api after this change.
Does this introduce a breaking change?
Other information
Internal blackbox test to validate 6.0.3.0 and trunk still works with this sdk bump passed successfully