Skip to content

Conversation

@fdrozdowski
Copy link
Contributor

@fdrozdowski fdrozdowski commented Jun 10, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Python packages are built and published to Test PyPi manually.

What is the new behavior?

This PR adds a GitHub action with the following behavior: when the dvp VERSION file (dvp/src/main/python/dlpx/virtualization/VERSION) is changed on master, develop, or release branch, we will build all Python packages and publish them to Test PyPi.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I have tested this action on my fork. I have verified that the action connects and tries to upload to Test PyPi (see https://github.com/fdrozdowski/virtualization-sdk/runs/759631255?check_suite_focus=true):

Uploading distributions to https://test.pypi.org/legacy/
Uploading dvp_common-2.1.0.dev2-py2-none-any.whl

  0%|          | 0.00/14.1k [00:00<?, ?B/s]
HTTPError: 400 Client Error: File already exists. See https://test.pypi.org/help/#file-name-reuse for url: https://test.pypi.org/legacy/
100%|##########| 14.1k/14.1k [00:00<00:00, 54.5kB/s]
NOTE: Try --verbose to see response content.
##[error]Process completed with exit code 1.

It ultimately fails because this version of the package already exists on Test PyPi. Otherwise, the package would be uploaded.

@fdrozdowski fdrozdowski linked an issue Jun 10, 2020 that may be closed by this pull request
@fdrozdowski fdrozdowski marked this pull request as ready for review June 10, 2020 22:34
@fdrozdowski fdrozdowski self-assigned this Jun 10, 2020
@fdrozdowski fdrozdowski changed the title Create gh action to build and publish packages to Test PyPi FIxes #74 CI/CD: Write release GH Action: build and publish Jun 10, 2020
@fdrozdowski fdrozdowski changed the title FIxes #74 CI/CD: Write release GH Action: build and publish Fixes #74 CI/CD: Write release GH Action: build and publish Jun 10, 2020
Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the publish fails for some reason? does it fail the push? where does it get logged so that we can diagnose future issues?

@fdrozdowski
Copy link
Contributor Author

@ankursarin The push won't be failed if the publish workflow fails. If the workflow fails, we will be notified with an e-mail and we will be able to see the logs under https://github.com/delphix/virtualization-sdk/actions.

@fdrozdowski fdrozdowski merged commit 8fec48b into delphix:develop Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD: Write release GH Action: build and publish

3 participants