Skip to content

Conversation

@fdrozdowski
Copy link
Contributor

@fdrozdowski fdrozdowski commented Jun 6, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We don't use wcwidth package in our code.

What is the new behavior?

Remove wcwidth from dependencies.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@fdrozdowski fdrozdowski marked this pull request as ready for review June 6, 2020 01:05
@fdrozdowski fdrozdowski merged commit 7fff973 into delphix:develop Jun 8, 2020
@fdrozdowski fdrozdowski deleted the remove_wcwidth branch June 8, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants