Skip to content

fixes #110 Write SDK docs with examples on how to add lua upgrades #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nhlien93 merged 7 commits into from
Jun 26, 2020
Merged

fixes #110 Write SDK docs with examples on how to add lua upgrades #170

nhlien93 merged 7 commits into from
Jun 26, 2020

Conversation

@nhlien93
Copy link
Contributor

@nhlien93 nhlien93 commented May 21, 2020 •
edited
Loading

Docs are published here: https://nhlien93.github.io/virtualization-sdk/Versioning_And_Upgrade/Lua_Toolkit_To_SDK_Plugin_Migration

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

@nhlien93 nhlien93 marked this pull request as ready for review May 21, 2020 03:36
mothslaw
mothslaw reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@mothslaw mothslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I know I left a lot of comments, but I have been appointed "grammar police", so I felt I should raise every little nit I could find. On the whole this is great.

jeffngo
jeffngo reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@jeffngo jeffngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great! Mostly grammar nits

mothslaw
mothslaw approved these changes Jun 23, 2020
View reviewed changes
jeffngo
jeffngo approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@jeffngo jeffngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

AleksandrLiber
AleksandrLiber approved these changes Jun 25, 2020
View reviewed changes
ravi-cm
ravi-cm approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Aleks on this latest diff - "Lua migrations will be executed ...." Looks good otherwise.

@nhlien93 nhlien93 merged commit 32c4312 into delphix:develop Jun 26, 2020
@nhlien93 nhlien93 deleted the luadocs branch June 26, 2020 03:40
@nhlien93 nhlien93 mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravi-cm ravi-cm ravi-cm approved these changes

@ankursarin ankursarin Awaiting requested review from ankursarin

@fdrozdowski fdrozdowski Awaiting requested review from fdrozdowski

@muralinimmagadda muralinimmagadda Awaiting requested review from muralinimmagadda

+3 more reviewers

@jeffngo jeffngo jeffngo approved these changes

@mothslaw mothslaw mothslaw approved these changes

@AleksandrLiber AleksandrLiber AleksandrLiber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nhlien93 @jeffngo @mothslaw @ravi-cm @AleksandrLiber