Skip to content

Conversation

@fdrozdowski
Copy link
Contributor

@fdrozdowski fdrozdowski commented May 12, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The linter GitHub action started failing with the following errors:

src/test/python/dlpx/virtualization/_internal/test_file_util.py:38:89: E501 line too long (92 > 88 characters)
src/test/python/dlpx/virtualization/_internal/test_file_util.py:89:89: E501 line too long (102 > 88 characters)
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:47:82: W291 trailing whitespace
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:50:1: W293 blank line contains whitespace
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:51:44: W291 trailing whitespace
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:83:9: F841 local variable 'manifest' is assigned to but never used
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:99:9: F841 local variable 'manifest' is assigned to but never used
src/test/python/dlpx/virtualization/_internal/test_plugin_importer.py:116:9: F841 local variable 'manifest' is assigned to but never used
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:445:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:445:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:504:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:504:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:504:89: E501 line too long (101 > 88 characters)
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:505:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:505:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:506:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:506:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:507:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:507:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:508:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:508:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:509:1: E101 indentation contains mixed spaces and tabs
src/test/python/dlpx/virtualization/_internal/commands/test_build.py:509:1: W191 indentation contains tabs
src/test/python/dlpx/virtualization/_internal/commands/test_codegen.py:374:89: E501 line too long (89 > 88 characters)

(see https://github.com/delphix/virtualization-sdk/pull/128/checks?check_run_id=668547116)

What is the new behavior?

Ran formatting and linting tools locally to fix all the precommit errors.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@fdrozdowski fdrozdowski marked this pull request as ready for review May 12, 2020 21:37
@fdrozdowski fdrozdowski changed the title Format and lint tools Fix linting and formatting problems in the tools package May 12, 2020
@fdrozdowski fdrozdowski changed the title Fix linting and formatting problems in the tools package Fix linting and formatting issues in the tools package May 12, 2020
@fdrozdowski fdrozdowski merged commit d62b54d into delphix:develop May 12, 2020
@fdrozdowski fdrozdowski deleted the fix-lint branch May 12, 2020 21:41
@fdrozdowski fdrozdowski added this to the VSDK Sprint 4/30-5/21 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants