Skip to content

PYT-868 Lua to Python - Change plugin config to expect optional lua name #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeffngo merged 2 commits into from
Apr 30, 2020
Merged

PYT-868 Lua to Python - Change plugin config to expect optional lua name #104

jeffngo merged 2 commits into from
Apr 30, 2020

Conversation

@jeffngo
Copy link
Contributor

@jeffngo jeffngo commented Apr 29, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

dvp build will not expect a luaName field in the plugin config

What is the new behavior?

dvp build will add the luaName property into the upload artifact if it exists

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jeffngo jeffngo added this to the VSDK Sprint 4/9 - 4/30 milestone Apr 29, 2020
@jeffngo jeffngo self-assigned this Apr 29, 2020
nhlien93
nhlien93 suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@nhlien93 nhlien93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should change the versioning to be the same format as filip's change. I think he should be pushing soon.

@jeffngo
Copy link
Contributor Author

jeffngo commented Apr 30, 2020

you should change the versioning to be the same format as filip's change. I think he should be pushing soon.

Sounds good. I'll wait for his push

ravi-cm
ravi-cm approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jeffngo jeffngo merged commit bd0193f into delphix:develop Apr 30, 2020
@muralinimmagadda muralinimmagadda mentioned this pull request May 6, 2020
Merged
muralinimmagadda pushed a commit to muralinimmagadda/virtualization-sdk that referenced this pull request May 6, 2020
@jeffngo @muralinimmagadda
PYT-868 Lua to Python - Change plugin config to expect optional lua n…
059a047 
…ame (delphix#104)
@jeffngo jeffngo linked an issue May 11, 2020 that may be closed by this pull request
Virtualization SDK Docs - New plugin config properties luaName and minimumLuaVersion #123
Closed
@jeffngo jeffngo linked an issue May 18, 2020 that may be closed by this pull request
Lua to Python - Change plugin config to expect optional luaName field #70
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravi-cm ravi-cm ravi-cm approved these changes

@ankursarin ankursarin Awaiting requested review from ankursarin

@fdrozdowski fdrozdowski Awaiting requested review from fdrozdowski

@mothslaw mothslaw Awaiting requested review from mothslaw

+1 more reviewer

@nhlien93 nhlien93 nhlien93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffngo jeffngo

Labels

Milestone-4 priority: P2

Milestone

VSDK Sprint 4/9 - 4/30

3 participants

@jeffngo @nhlien93 @ravi-cm